Skip to content

Arm backend: Disable model evaluation buck test#18915

Merged
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
digantdesai:export-D101046193
Apr 16, 2026
Merged

Arm backend: Disable model evaluation buck test#18915
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
digantdesai:export-D101046193

Conversation

@digantdesai
Copy link
Copy Markdown
Contributor

Summary: To unblock the diff train

Reviewed By: lucylq, psiddh, abhinaykukkadapu

Differential Revision: D101046193

Summary: To unblock the diff train

Reviewed By: lucylq, psiddh, abhinaykukkadapu

Differential Revision: D101046193
Copilot AI review requested due to automatic review settings April 15, 2026 22:28
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 15, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18915

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit a91a28c with merge base f84a17c (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Apr 15, 2026

@digantdesai has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101046193.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables the Arm backend’s model evaluation pytest from being registered as a Buck test target, intended to unblock the diff train.

Changes:

  • Commented out misc/test_evaluate_model.py in the Arm backend Buck test target list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 46 to 49
"misc/test_compile_spec.py",
"misc/test_evaluate_model.py",
# "misc/test_evaluate_model.py",
"misc/test_pass_pipeline_config.py",
"misc/test_tosa_spec.py",
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change disables misc/test_evaluate_model.py entirely (no Buck target will be generated), but there’s no tracking context for why it’s being turned off or when it should be re-enabled. Please add a short reason and a link to an issue/task (similar to the existing test_ioquantization_pass.py removal) and consider using a mechanism that still allows the test to be invoked manually (e.g., keep the target and skip/xfail within pytest or gate it on runtime.is_oss).

Copilot uses AI. Check for mistakes.
@meta-codesync meta-codesync Bot merged commit ec8d70b into pytorch:main Apr 16, 2026
167 of 177 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants