Arm backend: Disable model evaluation buck test#18915
Conversation
Summary: To unblock the diff train Reviewed By: lucylq, psiddh, abhinaykukkadapu Differential Revision: D101046193
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18915
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit a91a28c with merge base f84a17c ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@digantdesai has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101046193. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
Disables the Arm backend’s model evaluation pytest from being registered as a Buck test target, intended to unblock the diff train.
Changes:
- Commented out
misc/test_evaluate_model.pyin the Arm backend Buck test target list.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "misc/test_compile_spec.py", | ||
| "misc/test_evaluate_model.py", | ||
| # "misc/test_evaluate_model.py", | ||
| "misc/test_pass_pipeline_config.py", | ||
| "misc/test_tosa_spec.py", |
There was a problem hiding this comment.
This change disables misc/test_evaluate_model.py entirely (no Buck target will be generated), but there’s no tracking context for why it’s being turned off or when it should be re-enabled. Please add a short reason and a link to an issue/task (similar to the existing test_ioquantization_pass.py removal) and consider using a mechanism that still allows the test to be invoked manually (e.g., keep the target and skip/xfail within pytest or gate it on runtime.is_oss).
Summary: To unblock the diff train
Reviewed By: lucylq, psiddh, abhinaykukkadapu
Differential Revision: D101046193