Skip to content

fix format str#18916

Merged
digantdesai merged 1 commit into
mainfrom
lfq.format-string
Apr 15, 2026
Merged

fix format str#18916
digantdesai merged 1 commit into
mainfrom
lfq.format-string

Conversation

@lucylq
Copy link
Copy Markdown
Contributor

@lucylq lucylq commented Apr 15, 2026

^

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 15, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18916

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@lucylq lucylq marked this pull request as ready for review April 15, 2026 22:48
@lucylq lucylq requested a review from digantdesai as a code owner April 15, 2026 22:48
Copilot AI review requested due to automatic review settings April 15, 2026 22:48
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2026
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates error log format strings in the XNNPACK runtime compiler to correctly match the argument types being logged (notably FlatBuffers vector sizes).

Changes:

  • Adjusted ET_CHECK_OR_RETURN_ERROR format specifiers for constant_buffer bounds checks.
  • Adjusted ET_CHECK_OR_RETURN_ERROR format specifiers for constant_data bounds checks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@digantdesai digantdesai merged commit 2f339f0 into main Apr 15, 2026
161 of 165 checks passed
@digantdesai digantdesai deleted the lfq.format-string branch April 15, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants