From 321175b605a9fcd9a7fcc5d4312fbe77aaa8c385 Mon Sep 17 00:00:00 2001 From: RJ Ascani Date: Wed, 22 Apr 2026 10:32:31 -0700 Subject: [PATCH] Third-party: Disable -Werror for flatcc build Apple Clang 21 (Xcode 26) elevates -Wimplicit-int-conversion-on-negation and -Wunterminated-string-initialization to errors, which breaks the vendored flatcc build at pprintint.h and grisu3_print.h. The warnings are benign and the fix belongs upstream in dvidelabs/flatcc; disable -Werror locally via FLATCC_ALLOW_WERROR=OFF for both the flatcc_ep external project (host compiler) and the in-tree flatccrt runtime lib. Authored with Claude. --- third-party/CMakeLists.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/third-party/CMakeLists.txt b/third-party/CMakeLists.txt index 93ce08bdc7d..e744561fa8e 100644 --- a/third-party/CMakeLists.txt +++ b/third-party/CMakeLists.txt @@ -91,6 +91,7 @@ ExternalProject_Add( -DFLATCC_TEST=OFF -DFLATCC_REFLECTION=OFF -DFLATCC_DEBUG_CLANG_SANITIZE=OFF + -DFLATCC_ALLOW_WERROR=OFF -DFLATCC_INSTALL=ON -DCMAKE_POLICY_VERSION_MINIMUM=3.5 -DCMAKE_INSTALL_PREFIX:PATH= @@ -116,6 +117,7 @@ set(FLATCC_RTONLY ON CACHE BOOL "") set(FLATCC_TEST OFF CACHE BOOL "") set(FLATCC_REFLECTION OFF CACHE BOOL "") set(FLATCC_DEBUG_CLANG_SANITIZE OFF CACHE BOOL "") +set(FLATCC_ALLOW_WERROR OFF CACHE BOOL "") set(FLATCC_INSTALL OFF CACHE BOOL "") add_subdirectory(flatcc) # Unfortunately flatcc writes libs directly in to the source tree [1]. So to