Third-party: Disable -Werror for flatcc build#19049
Conversation
Apple Clang 21 (Xcode 26) elevates -Wimplicit-int-conversion-on-negation and -Wunterminated-string-initialization to errors, which breaks the vendored flatcc build at pprintint.h and grisu3_print.h. The warnings are benign and the fix belongs upstream in dvidelabs/flatcc; disable -Werror locally via FLATCC_ALLOW_WERROR=OFF for both the flatcc_ep external project (host compiler) and the in-tree flatccrt runtime lib. Authored with Claude.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19049
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 1 PendingAs of commit cf902a0 with merge base 5b89d23 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
2 participants
Summary
Apple Clang 21 (Xcode 26) elevates -Wimplicit-int-conversion-on-negation and -Wunterminated-string-initialization to errors, which breaks the vendored flatcc build at pprintint.h and grisu3_print.h. The warnings are benign and the fix belongs upstream in dvidelabs/flatcc; disable -Werror locally via FLATCC_ALLOW_WERROR=OFF for both the flatcc_ep external project (host compiler) and the in-tree flatccrt runtime lib.
Test plan
Authored with Claude.