Skip to content

NXP backend: Fix passing env to executor cmd#19063

Merged
roman-janik-nxp merged 1 commit into
pytorch:mainfrom
nxp-upstream:feature/nxg11066/EIEX-696-Fix-passing-env-to-executor-cmd
Apr 23, 2026
Merged

NXP backend: Fix passing env to executor cmd#19063
roman-janik-nxp merged 1 commit into
pytorch:mainfrom
nxp-upstream:feature/nxg11066/EIEX-696-Fix-passing-env-to-executor-cmd

Conversation

@roman-janik-nxp
Copy link
Copy Markdown
Collaborator

@roman-janik-nxp roman-janik-nxp commented Apr 23, 2026

Summary

Fix of passing current env to subprocess call in execute_cmd(). Previous state where new env with 1 varible was passed prevented some tools from working correctly when call through subprocess call.

Test plan

Test for NXP executor runner.

cc @robert-kalmar

@roman-janik-nxp roman-janik-nxp added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Apr 23, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 23, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19063

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 1 Cancelled Job, 2 Unrelated Failures

As of commit 36f787c with merge base c48ea12 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2026
@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-696-Fix-passing-env-to-executor-cmd branch from bdc9852 to 36f787c Compare April 23, 2026 09:13
@roman-janik-nxp
Copy link
Copy Markdown
Collaborator Author

The failing checks seem unrelated and the internal build passed. Merging.

@roman-janik-nxp roman-janik-nxp merged commit 9ce1b55 into pytorch:main Apr 23, 2026
165 of 171 checks passed
@roman-janik-nxp roman-janik-nxp deleted the feature/nxg11066/EIEX-696-Fix-passing-env-to-executor-cmd branch April 23, 2026 11:51
zeel2104 pushed a commit to zeel2104/executorch that referenced this pull request May 5, 2026
### Summary
Fix of passing current env to subprocess call in execute_cmd(). Previous
state where new env with 1 varible was passed prevented some tools from
working correctly when call through subprocess call.

### Test plan
Test for NXP executor runner.


cc @robert-kalmar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants