Skip to content

Fix pin bump CI handler not triggering on workflow_run #19090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JacobSzwejbka wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −6
Open

Fix pin bump CI handler not triggering on workflow_run #19090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions .github/workflows/pin-bump-ci-handler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,24 @@ jobs:
const workflowRun = context.payload.workflow_run;
const conclusion = workflowRun.conclusion;
const runUrl = workflowRun.html_url;
const headBranch = workflowRun.head_branch;

// Find PR by branch name (workflow_run.pull_requests is unreliable)
let prNumber;
const prs = workflowRun.pull_requests;
if (!prs || prs.length === 0) {
console.log('No PRs associated with this workflow run. Skipping.');
return;
if (prs && prs.length > 0) {
prNumber = prs[0].number;
} else {
const { data: branchPrs } = await github.rest.pulls.list({
owner, repo, head: `${owner}:${headBranch}`, state: 'open', per_page: 1
});
if (branchPrs.length === 0) {
console.log(`No open PRs for branch ${headBranch}. Skipping.`);
return;
}
prNumber = branchPrs[0].number;
}

const prNumber = prs[0].number;
const pr = await github.rest.pulls.get({ owner, repo, pull_number: prNumber });

const isPinBump = pr.data.labels.some(l => l.name === 'ci/pytorch-pin-bump');
Expand Down Expand Up @@ -65,8 +75,8 @@ jobs:
return;
}

if (conclusion !== 'failure') {
console.log(`Trunk concluded with "${conclusion}" (not failure). Skipping.`);
if (conclusion !== 'failure' && conclusion !== 'cancelled') {
console.log(`Trunk concluded with "${conclusion}" (not failure/cancelled). Skipping.`);
return;
}

Expand Down
Loading