Skip to content

Arm backend: Update while_loop in control-flow quant folding#19109

Open
SaoirseARM wants to merge 2 commits intopytorch:mainfrom
SaoirseARM:toupstream/while
Open

Arm backend: Update while_loop in control-flow quant folding#19109
SaoirseARM wants to merge 2 commits intopytorch:mainfrom
SaoirseARM:toupstream/while

Conversation

@SaoirseARM
Copy link
Copy Markdown
Collaborator

@SaoirseARM SaoirseARM commented Apr 24, 2026

Summary

Update quantization annotation of while loop to ensure when additional inputs are provided such as threshold, quantization parameters are different.

  • add node.meta["additional_inputs"] to ensure when threshold is used different quantization parameters are used.
  • Update to quant folding to merge these if different

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

- add node.meta["additional_inputs"] to ensure when threshold is used
different quantization parameters are used.
- Update to quant folding to merge these if different

Signed-off-by: Saoirse Stewart <saoirse.stewart@arm.com>
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 24, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19109

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 2 Cancelled Jobs, 1 Pending, 4 Unrelated Failures

As of commit 33bfa4f with merge base 32a6cec (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Apr 24, 2026
@SaoirseARM
Copy link
Copy Markdown
Collaborator Author

@pytorchbot label ciflow/trunk

@SaoirseARM
Copy link
Copy Markdown
Collaborator Author

@pytorchbot label 'partner: arm'

@pytorch-bot pytorch-bot Bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Apr 24, 2026
@SaoirseARM
Copy link
Copy Markdown
Collaborator Author

@pytorchbot label "release notes: arm"

@pytorch-bot pytorch-bot Bot added the release notes: arm Changes to the ARM backend delegate label Apr 24, 2026
Copy link
Copy Markdown
Collaborator

@zingo zingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge but if possible/OK after #18948 or make sure it does not conflict with that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants