-
Notifications
You must be signed in to change notification settings - Fork 988
Place model PTE in DDR to fix FVP link-time memory overflow #19199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b6366da
Place model PTE in DDR to fix FVP link-time memory overflow
psiddh 39d3f7d
Fix MV2 runtime pool sizes and skip Corstone-300 in CI
psiddh b1939e9
Fix linker section pattern to match pte_to_header.py output
psiddh e5a7f6f
Merge branch 'main' into fix-mv2-fvp-memory-overflow
psiddh 9d70310
MV2 CI: build-only for all targets to avoid FVP timeout
psiddh 03bf8c8
Add SPDX license header to model_section.ld.in
psiddh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
zephyr/samples/mv2-ethosu/boards/mps4_corstone320_fvp.overlay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * Copyright 2026 Arm Limited and/or its affiliates. | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| /* Override zephyr,sram to the 4 MiB ISRAM (0x3100_0000) so the allocator | ||
| * pools (~3 MiB total) fit alongside code in the same region. The default | ||
| * sram@12000000 is only 2 MiB which is too small for MV2. | ||
| * | ||
| * The model PTE blob is placed in DDR (0x7000_0000) via a linker snippet. | ||
| * The Ethos-U can DMA from DDR on the Corstone-320 FVP. | ||
| */ | ||
| / { | ||
| chosen { | ||
| zephyr,sram = &isram; | ||
| }; | ||
|
|
||
| model_ddr: memory@70000000 { | ||
| compatible = "zephyr,memory-region", "mmio-sram"; | ||
| reg = <0x70000000 DT_SIZE_M(16)>; | ||
| zephyr,memory-region = "MODEL_DDR"; | ||
| }; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| /* Place the model PTE blob in DDR so it does not overflow the small | ||
| * ITCM (FLASH) and ISRAM (RAM) regions on Corstone FVP boards. | ||
| * The Ethos-U NPU can DMA from DDR on these platforms. | ||
| * | ||
| * Section name is substituted from the ET_PTE_SECTION CMake variable | ||
| * so this stays in sync with pte_to_header.py --section. | ||
| */ | ||
| SECTION_DATA_PROLOGUE(@ET_PTE_SECTION@,,) | ||
| { | ||
| . = ALIGN(16); | ||
| *(@ET_PTE_SECTION@) | ||
| *(@ET_PTE_SECTION@.*) | ||
| } GROUP_DATA_LINK_IN(MODEL_DDR, MODEL_DDR) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.