Skip to content

Add libextension_memory_allocator.a to executorch_llm Apple framework#19200

Merged
rascani merged 1 commit intopytorch:mainfrom
rascani:fix/apple-framework-memory-allocator
Apr 29, 2026
Merged

Add libextension_memory_allocator.a to executorch_llm Apple framework#19200
rascani merged 1 commit intopytorch:mainfrom
rascani:fix/apple-framework-memory-allocator

Conversation

@rascani
Copy link
Copy Markdown
Contributor

@rascani rascani commented Apr 28, 2026

Summary

PR #15730 added a dependency from extension/llm/runner on extension::CPUCachingAllocator (defined in libextension_memory_allocator.a) but did not update scripts/build_apple_frameworks.sh, so the executorch_llm iOS framework was missing the symbol. This caused the Benchmark Tests target to fail with Undefined symbols: CPUCachingAllocator(unsigned int), breaking the Apple/build-benchmark-app job on trunk.

Authored with the assistance of Claude (Anthropic).

Test plan

CI

@rascani
Add libextension_memory_allocator.a to executorch_llm Apple framework
3570aaf 
PR pytorch#15730 added a dependency from extension/llm/runner on
extension::CPUCachingAllocator (defined in libextension_memory_allocator.a)
but did not update scripts/build_apple_frameworks.sh, so the executorch_llm
iOS framework was missing the symbol. This caused the Benchmark Tests
target to fail with `Undefined symbols: CPUCachingAllocator(unsigned int)`,
breaking the Apple/build-benchmark-app job on trunk.

Authored with the assistance of Claude (Anthropic).
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 28, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19200

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 17 Pending

As of commit 3570aaf with merge base 9207001 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 28, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@rascani rascani marked this pull request as ready for review April 28, 2026 23:24
@rascani rascani requested a review from GregoryComer as a code owner April 28, 2026 23:24
@psiddh psiddh self-requested a review April 28, 2026 23:27
@rascani rascani merged commit 5a206ab into pytorch:main Apr 29, 2026
454 of 463 checks passed
@rascani rascani deleted the fix/apple-framework-memory-allocator branch April 29, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psiddh psiddh psiddh approved these changes

@GregoryComer GregoryComer GregoryComer approved these changes

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rascani @psiddh @GregoryComer