Skip to content

[QNN] Add SM8635 (Snapdragon 8s Gen 3) and SM8735 (Snapdragon 8s Gen 4) chipset support#19216

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/add-support-for-sm8735-chip
Draft

[QNN] Add SM8635 (Snapdragon 8s Gen 3) and SM8735 (Snapdragon 8s Gen 4) chipset support#19216
Copilot wants to merge 2 commits intomainfrom
copilot/add-support-for-sm8735-chip

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 29, 2026 •
edited
Loading

The Qualcomm 's' series chipsets (SM8635, SM8735) were missing from the QNN backend despite having compatible Hexagon HTP hardware supported by the QNN SDK.

Changes

  • qc_compiler_spec.fbs — Add SM8635 = 68 and SM8735 = 85 to QcomChipset enum
  • qc_schema.py — Add both chips to QcomChipset IntEnum and _soc_info_table:
    • SM8635: SoC Model 68, V73 arch, 8MB VTCM (same arch as SM8550)
    • SM8735: SoC Model 85, V79 arch, 8MB VTCM (same arch as SM8750)
  • utils.py — Update get_soc_to_htp_arch_map(), get_soc_to_chipset_map(), and the compiler spec docstring
  • README.md — Replace the incorrect note "chipset IDs are not accessible to community users" with a pointer to the QNN SDK's "Supported Snapdragon Devices" table where SoC model integers are documented

SoC model IDs verified from QNN_SOC_MODEL_SM8635 / QNN_SOC_MODEL_SM8735 constants in the QNN SDK's QnnTypes.h.

Test plan

Validated that QcomChipset.SM8635 and QcomChipset.SM8735 resolve correctly with the expected HTP arch and VTCM values, and that _soc_info_table lookups succeed:

from backends.qualcomm.serialization.qc_schema import QcomChipset, _soc_info_table, HtpArch

assert QcomChipset.SM8635.value == 68
assert QcomChipset.SM8735.value == 85
assert _soc_info_table[QcomChipset.SM8635].htp_info.htp_arch == HtpArch.V73
assert _soc_info_table[QcomChipset.SM8735].htp_info.htp_arch == HtpArch.V79

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • aihub.qualcomm.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
  • android.googlesource.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
  • developer.qualcomm.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
  • discuss.pytorch.org
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
  • docs.qualcomm.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
  • https://api.github.com/repos/quic/ai-hub-models/contents/
    • Triggering command: `/usr/bin/python3 python3 -c
      import urllib.request

Check quic/ai-hub-models

try:
url = 'REDACTED'
r = urllib.request.urlopen(url, timeout=10)
content = r.read().decode()
for line i e/backends/ir/IrBackend.h e/ba�� e/backends/QnnProfiler.h e/backends/QnnContextCommon.h e/backends/htp/HtpDevicePlatformInfoConfig.h e/backends/htp/Hgrep e/backends/htp/H-n e/backends/htp/HSM8|Snapdragon|soc_model e/backends/htp/H/home/REDACTED/.local/lib/python3.12/site-packages/qai_hub/client.py e/ba�� e/backends/htp/HtpGraph.h e/backends/htp/HtpContext.h stable-x86_64-REDACTED-linux-gnu/bin/rustc committer.email` (http block)

  • softwarecenter.qualcomm.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
    • Triggering command: `/usr/bin/python3 python3 -c

Let's look at QNN examples in the AI Engine Direct SDK for newer chip refs

import urllib.request
try:
r = urllib.request.urlopen('REDACTED` (dns block)

  • Triggering command: `/usr/bin/python3 python3 -c
    import urllib.request

Look for newer versions of QAIRT documentation

for version in ['2.26', '2.27', '2.28', '2.29', '2.30', '2.31', '2.32', '2.33', '2.34', '2.35']:
url = f'REDACTED` (dns block)

  • web.archive.org
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
  • webcache.googleusercontent.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
  • www.notebookcheck.net
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
  • www.qualcomm.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 29, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19216

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copilot AI linked an issue Apr 29, 2026 that may be closed by this pull request
[QNN] AttributeError: SM8735. Did you mean: 'SM8350'? #19141
Open
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 29, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 29, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kirklandsign
Add SM8635 (Snapdragon 8s Gen 3) and SM8735 (Snapdragon 8s Gen 4) chi…
0102ef0 
…pset support

Agent-Logs-Url: https://github.com/pytorch/executorch/sessions/3e9acd79-6c85-4c6c-860f-e364207f8e23

Co-authored-by: kirklandsign <107070759+kirklandsign@users.noreply.github.com>
Copilot AI changed the title [WIP] Add support for SM8735 chip in QNN SDK [QNN] Add SM8635 (Snapdragon 8s Gen 3) and SM8735 (Snapdragon 8s Gen 4) chipset support Apr 30, 2026
Copilot AI requested a review from kirklandsign April 30, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirklandsign kirklandsign Awaiting requested review from kirklandsign

@abhinaykukkadapu abhinaykukkadapu Awaiting requested review from abhinaykukkadapu abhinaykukkadapu will be requested when the pull request is marked ready for review abhinaykukkadapu is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@kirklandsign kirklandsign

Copilot code review Copilot

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[QNN] AttributeError: SM8735. Did you mean: 'SM8350'?

2 participants

@kirklandsign