Skip to content

make quantized_max_pool2d_nhwc handle case of C>64 (#19238)#19238

Open
wl1026sun wants to merge 1 commit intopytorch:mainfrom
wl1026sun:export-D103096179
Open

make quantized_max_pool2d_nhwc handle case of C>64 (#19238)#19238
wl1026sun wants to merge 1 commit intopytorch:mainfrom
wl1026sun:export-D103096179

Conversation

@wl1026sun
Copy link
Copy Markdown
Contributor

@wl1026sun wl1026sun commented Apr 30, 2026

Summary:

now the TIE quantized_max_pool2d_nhwc general path processes channels in chunks of 16 groups (64 bytes) at a time using a fixed stack array with an outer loop. This supports arbitrary C (any multiple of 4).
Also adds test cases for C=128, C=256, k=3x3, and padding to cover all TIE kernel dispatch paths.

Reviewed By: khazaei

Differential Revision: D103096179

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 30, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19238

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Awaiting Approval, 1 New Failure, 1 Pending, 3 Unrelated Failures

As of commit eb3a4de with merge base 94d2881 (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 30, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Apr 30, 2026

@wl1026sun has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103096179.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@wl1026sun wl1026sun force-pushed the export-D103096179 branch from b90b2ec to 835e67c Compare May 1, 2026 01:06
@meta-codesync meta-codesync Bot changed the title make quantized_max_pool2d_nhwc handle case of C>64 make quantized_max_pool2d_nhwc handle case of C>64 (#19238) May 1, 2026
wl1026sun added a commit to wl1026sun/executorch that referenced this pull request May 1, 2026
Summary:

now the TIE quantized_max_pool2d_nhwc general path processes channels in chunks of 16 groups (64 bytes) at a time using a fixed stack array with an outer loop. This supports arbitrary C (any multiple of 4).
Also adds test cases for C=128, C=256, k=3x3, and padding to cover all TIE kernel dispatch paths.

Reviewed By: khazaei

Differential Revision: D103096179
@wl1026sun wl1026sun force-pushed the export-D103096179 branch from 835e67c to 1c24640 Compare May 1, 2026 01:08
Summary:

now the TIE quantized_max_pool2d_nhwc general path processes channels in chunks of 16 groups (64 bytes) at a time using a fixed stack array with an outer loop. This supports arbitrary C (any multiple of 4).
Also adds test cases for C=128, C=256, k=3x3, and padding to cover all TIE kernel dispatch paths.

Reviewed By: khazaei

Differential Revision: D103096179
@wl1026sun wl1026sun force-pushed the export-D103096179 branch from 1c24640 to eb3a4de Compare May 1, 2026 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant