Skip to content

fix export issue#19240

Open
billmguo wants to merge 1 commit intopytorch:mainfrom
billmguo:export-D103306388
Open

fix export issue#19240
billmguo wants to merge 1 commit intopytorch:mainfrom
billmguo:export-D103306388

Conversation

@billmguo
Copy link
Copy Markdown
Contributor

Summary:
Root cause: decompose_wrap_with_autocast.py:64 built the remap dict keyed by the parent graph's argument node names (n_args[i].name), but merge_decomposed_graph looks up entries by the decomposed submodule's placeholder names (decomposed_node.name). After 17 prior QNN passes transform the graph, argument nodes get renamed/replaced, causing the names to diverge. The placeholder 'permute_3' in the submodule no longer matches any key in remap.

Fix: Build remap by extracting placeholders from the decomposed submodule and mapping them positionally to n_args[5:], which is the correct correspondence regardless of node naming. This matches the pattern all other callers of merge_decomposed_graph use (hardcoded placeholder names from modules they control).

Differential Revision: D103306388

Summary:
Root cause: decompose_wrap_with_autocast.py:64 built the remap dict keyed by the parent graph's argument node names (n_args[i].name), but merge_decomposed_graph looks up entries by the decomposed submodule's placeholder names (decomposed_node.name). After 17 prior QNN passes transform the graph, argument nodes get renamed/replaced, causing the names to diverge. The placeholder 'permute_3' in the submodule no longer matches any key in remap.

Fix: Build remap by extracting placeholders from the decomposed submodule and mapping them positionally to n_args[5:], which is the correct correspondence regardless of node naming. This matches the pattern all other callers of merge_decomposed_graph use (hardcoded placeholder names from modules they control).

Differential Revision: D103306388
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 30, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19240

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 37ee96a with merge base 2108986 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 30, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Apr 30, 2026

@billmguo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103306388.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant