fix export issue#19240
Conversation
Summary: Root cause: decompose_wrap_with_autocast.py:64 built the remap dict keyed by the parent graph's argument node names (n_args[i].name), but merge_decomposed_graph looks up entries by the decomposed submodule's placeholder names (decomposed_node.name). After 17 prior QNN passes transform the graph, argument nodes get renamed/replaced, causing the names to diverge. The placeholder 'permute_3' in the submodule no longer matches any key in remap. Fix: Build remap by extracting placeholders from the decomposed submodule and mapping them positionally to n_args[5:], which is the correct correspondence regardless of node naming. This matches the pattern all other callers of merge_decomposed_graph use (hardcoded placeholder names from modules they control). Differential Revision: D103306388
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19240
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 37ee96a with merge base 2108986 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@billmguo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103306388. |
This PR needs a
|
Summary:
Root cause: decompose_wrap_with_autocast.py:64 built the remap dict keyed by the parent graph's argument node names (n_args[i].name), but merge_decomposed_graph looks up entries by the decomposed submodule's placeholder names (decomposed_node.name). After 17 prior QNN passes transform the graph, argument nodes get renamed/replaced, causing the names to diverge. The placeholder 'permute_3' in the submodule no longer matches any key in remap.
Fix: Build remap by extracting placeholders from the decomposed submodule and mapping them positionally to n_args[5:], which is the correct correspondence regardless of node naming. This matches the pattern all other callers of merge_decomposed_graph use (hardcoded placeholder names from modules they control).
Differential Revision: D103306388