Add regression tests for previously-failing CoreML lowerings#19248
Add regression tests for previously-failing CoreML lowerings#19248john-rocky wants to merge 2 commits intopytorch:mainfrom
Conversation
These models were filed as crashes against the CoreML partitioner / backend in mid-2025 (pytorch#11688, pytorch#11691, pytorch#11701, pytorch#11702, pytorch#11708, pytorch#11709). All six lower successfully on the current toolchain (executorch main + coremltools 9.0); add them to the partitioner test suite so any future regression that re-breaks one of them is caught in CI.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19248
Note: Links to docs will display an error until the docs builds have been completed.
|
|
Hi @john-rocky! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
This PR needs a
|
6d191fa to
31f0692
Compare
Summary
Six bugs filed against the CoreML partitioner / backend in mid-2025 no
longer reproduce on the current toolchain (executorch
main+ coremltools 9.0):Conv1d(stride=8, dilation=2, groups=2)segfaultint32matmul with a constant weight failed to loadBatchNorm3dcrashed during compilationInstanceNorm3dfailed at compile withinvalid rank 5ReflectionPad3dfailed to load with the >2-spatial-dim pad errorReplicationPad3dsame as CoreML ReflectionPad3d fails to load at runtime #11708I verified each repro on macOS 15 / Python 3.10 / coremltools 9.0 and they
now lower cleanly. This PR adds them to
test_coreml_partitioner.pysothe wins are pinned in CI, and any future change that regresses one of
them surfaces immediately.
Test plan
The test is a single method with one
self.subTest(name=...)per issue so are-regression of any one case is reported individually. I'm happy to follow
up with separate "closes" comments / closes on the issues themselves once
this lands.
Authored with Claude.