Skip to content

Arm backend: Fix integer overflow in VGFBackend IO size computation #19256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lucylq wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −4
Draft

Arm backend: Fix integer overflow in VGFBackend IO size computation #19256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions backends/arm/runtime/VGFBackend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@
* LICENSE file in the root directory of this source tree.
*/

#include <cinttypes>
#include <list>
#include <numeric>
using namespace std;

#include <c10/util/safe_numerics.h>
#include <executorch/runtime/backend/interface.h>
#include <executorch/runtime/core/error.h>
#include <executorch/runtime/core/evalue.h>
Expand Down Expand Up @@ -190,8 +192,18 @@ class VGFBackend final : public ::executorch::runtime::BackendInterface {
if (!io->is_input)
continue;

size_t io_size = accumulate(
io->size.begin(), io->size.end(), io->elt_size, std::multiplies<>());
size_t io_size = io->elt_size;
for (int64_t dim : io->size) {
ET_CHECK_OR_RETURN_ERROR(
dim >= 0,
InvalidArgument,
"Negative dimension in IO size: %" PRId64,
dim);
ET_CHECK_OR_RETURN_ERROR(
!c10::mul_overflows(io_size, static_cast<size_t>(dim), &io_size),
InvalidArgument,
"Overflow computing IO buffer size");
}

void* data;
if (!repr->map_io(io, &data)) {
Expand Down Expand Up @@ -225,8 +237,18 @@ class VGFBackend final : public ::executorch::runtime::BackendInterface {
if (io->is_input)
continue;

size_t io_size = accumulate(
io->size.begin(), io->size.end(), io->elt_size, std::multiplies<>());
size_t io_size = io->elt_size;
for (int64_t dim : io->size) {
ET_CHECK_OR_RETURN_ERROR(
dim >= 0,
InvalidArgument,
"Negative dimension in IO size: %" PRId64,
dim);
ET_CHECK_OR_RETURN_ERROR(
!c10::mul_overflows(io_size, static_cast<size_t>(dim), &io_size),
InvalidArgument,
"Overflow computing IO buffer size");
}

void* data;
if (!repr->map_io(io, &data)) {
Expand Down
Loading