Skip to content

Run XNNPACK passes with backed_size_oblivious#19262

Open
GregoryComer wants to merge 1 commit intopytorch:mainfrom
GregoryComer:export-D102676211
Open

Run XNNPACK passes with backed_size_oblivious#19262
GregoryComer wants to merge 1 commit intopytorch:mainfrom
GregoryComer:export-D102676211

Conversation

@GregoryComer
Copy link
Copy Markdown
Member

Summary:
Run XNNPACK backend-specific passes with backed_size_oblivious=True. This prevents unwanted guards and shape narrowing introduced by ATen backend selection.

This fixes a case where the decompose batch norm pass narrows dynamic batch range because the batchnorm -> pointwise conv rewrite triggers an ATen guard. I added a test which previously reproed the issue and now passes with this change.

Differential Revision: D102676211

Summary:
Run XNNPACK backend-specific passes with backed_size_oblivious=True. This prevents unwanted guards and shape narrowing introduced by ATen backend selection.

This fixes a case where the decompose batch norm pass narrows dynamic batch range because the batchnorm -> pointwise conv rewrite triggers an ATen guard. I added a test which previously reproed the issue and now passes with this change.

Differential Revision: D102676211
@GregoryComer GregoryComer requested a review from digantdesai as a code owner May 1, 2026 20:24
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 1, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19262

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Cancelled Job, 2 Unrelated Failures

As of commit 447b770 with merge base a7e44bf (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 1, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 1, 2026

@GregoryComer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102676211.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant