Skip to content

Add missing program_builder dep to arm test targets#19266

Open
rascani wants to merge 2 commits intopytorch:mainfrom
rascani:export-D103456950
Open

Add missing program_builder dep to arm test targets#19266
rascani wants to merge 2 commits intopytorch:mainfrom
rascani:export-D103456950

Conversation

@rascani
Copy link
Copy Markdown
Contributor

@rascani rascani commented May 1, 2026

Summary:
D102325968 added an import of executorch.backends.test.program_builder in test_fuse_constant_ops_pass.py but only updated the xplat targets.bzl with the corresponding Buck dependency. The fbcode targets.bzl was missing this dependency, causing test listing failures for fbcode//executorch/backends/arm/test:fuse_constant_ops_pass.

Add //executorch/backends/test:program_builder to the deps list.

Differential Revision: D103456950

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

Summary:
D102325968 added an import of `executorch.backends.test.program_builder` in `test_fuse_constant_ops_pass.py` but only updated the xplat `targets.bzl` with the corresponding Buck dependency. The fbcode `targets.bzl` was missing this dependency, causing test listing failures for `fbcode//executorch/backends/arm/test:fuse_constant_ops_pass`.

Add `//executorch/backends/test:program_builder` to the deps list.

Differential Revision: D103456950
@rascani rascani requested a review from digantdesai as a code owner May 1, 2026 21:11
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 1, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19266

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 1 Pending, 3 Unrelated Failures

As of commit 37843bd with merge base 8464b47 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 1, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 1, 2026

@rascani has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103456950.

@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels May 1, 2026
@rascani rascani changed the title Add missing program_builder dep to fbcode arm test targets Add missing program_builder dep to arm test targets May 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant