NXP backend - added support for aten.abs using the new Neutron flow#19328
NXP backend - added support for aten.abs using the new Neutron flow#19328novak-vaclav wants to merge 4 commits intopytorch:mainfrom
aten.abs using the new Neutron flow#19328Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19328
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 77 Pending, 2 Unrelated FailuresAs of commit de1a240 with merge base 1debeb6 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "module: nxp" |
|
@pytorchbot label "release notes: nxp" |
There was a problem hiding this comment.
Pull request overview
Adds aten.abs delegation support for the NXP backend when using the new Neutron-C (MLIR-based) flow, and expands test coverage to exercise both legacy and new-flow behavior.
Changes:
- Added new-flow target support gating for
aten.abs(currently limited to QDQ quantizedint8/uint8) in the Abs node converter. - Refactored/extended
test_abs_converter.pyto split legacy vs new Neutron flow tests and add NSYS-based lower/run/compare coverage for the new flow. - Updated NXP copyright headers to include 2026.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| backends/nxp/tests/ir/converter/node_converter/test_abs_converter.py | Splits legacy/new-flow tests and adds NSYS-based new-flow runtime validation for abs (including a conv+abs partitioning case). |
| backends/nxp/backend/ir/converter/node_converters/ops_converters/abs_converter.py | Adds new-flow target support checks for abs based on QDQ quantized IO dtype (int8/uint8). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ec37498 to
7f474aa
Compare
7f474aa to
420ab94
Compare
|
Rebased onto #19327 Please review @MartinPavella |
420ab94 to
429d160
Compare
|
Fixed the alphabetical order in |
429d160 to
ec37498
Compare
ec37498 to
56d50d2
Compare
|
Rebased onto to up-to-date changes in #19327 |
56d50d2 to
de1a240
Compare
|
@MartinPavella Thank you 😊 |
Summary
Added support for
aten.absusing new Neutron flow.Test plan
tests can be manually run using
pytest -c /dev/null backends/nxp/tests/cc @robert-kalmar @JakeStevens @digantdesai @MartinPavella