test_partitioner_with_spec: accept Python 3.12 setter error message#19382
test_partitioner_with_spec: accept Python 3.12 setter error message#19382rascani wants to merge 1 commit intopytorch:mainfrom
Conversation
Summary: Python 3.12 changed the AttributeError message emitted when assigning to a property without a setter, from "can't set attribute 'spec'" to "property 'spec' of 'CustomPartitioner' object has no setter". The `assertRaisesRegex` in `test_partitioner_with_spec` only matched the pre-3.12 form, so the test failed on the Python 3.12 runtime. Updated the regex to match either form. Authored with Claude. Differential Revision: D104316540
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19382
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 PendingAs of commit 231216d with merge base fa857bd ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
|
@rascani has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104316540. |
This PR needs a
|
1 participant
Summary:
Python 3.12 changed the AttributeError message emitted when assigning to a property without a setter, from "can't set attribute 'spec'" to "property 'spec' of 'CustomPartitioner' object has no setter". The
assertRaisesRegexintest_partitioner_with_speconly matched the pre-3.12 form, so the test failed on the Python 3.12 runtime.Updated the regex to match either form.
Authored with Claude.
Differential Revision: D104316540