Arm backend: Fix public API manifest test#19389
Open
martinlsm wants to merge 2 commits intopytorch:mainfrom
Open
Arm backend: Fix public API manifest test#19389martinlsm wants to merge 2 commits intopytorch:mainfrom
martinlsm wants to merge 2 commits intopytorch:mainfrom
Conversation
Ignore unstable lazy imports when checking top-level manifest entries. Signed-off-by: Martin Lindström <Martin.Lindstroem@arm.com> Change-Id: Ia6c9d14a3a2f21cf534f90fcf1dc12f9d36eab59
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19389
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 146b92c with merge base 991c37f ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Collaborator
Author
|
@pytorchbot label "partner: arm" |
pytorch-bot
Bot
added
the
partner: arm
Collaborator
Author
|
@pytorchbot label "release notes: none" |
pytorch-bot
Bot
added
the
release notes: none
Collaborator
Author
|
@pytorchbot label ciflow/trunk |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Arm backend public API manifest test to align its top-level entry expectations with the manifest generator behavior by excluding symbols considered “unstable” (deprecated/experimental).
Changes:
- Import the Arm backend module in the test so it can resolve lazy-exported symbols.
- Recompute the expected top-level manifest entries by filtering
LAZY_IMPORTSthrough_is_unstable_api(...). - Update the assertion to compare collected entries against the filtered expected set.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sebastian-Larsson
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore unstable lazy imports when checking top-level manifest entries.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell