Arm backend: Fix transposed conv lowering#19391
Open
Christoffer-JL wants to merge 1 commit intopytorch:mainfrom
Open
Arm backend: Fix transposed conv lowering#19391Christoffer-JL wants to merge 1 commit intopytorch:mainfrom
Christoffer-JL wants to merge 1 commit intopytorch:mainfrom
Conversation
Avoid accidentally slicing transpose convolutions. Input slicing is used for regular convolutions to trim unused edge regions for TOSA lowering, but that is not valid for transpose convolutions. Shrinking the input to a transpose convolution changes the expanded output shape and can break output_padding cases. Signed-off-by: Christoffer J.L <christoffer.johanssonlundqvist@arm.com> Change-Id: Ib3e349310bf1672ea1cce366154101aed1415e6e
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19391
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Pending, 4 Unrelated FailuresAs of commit c072133 with merge base 69989b7 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid accidentally slicing transpose convolutions.
Input slicing is used for regular convolutions to trim unused edge regions for TOSA lowering, but that is not valid for transpose convolutions. Shrinking the input to a transpose convolution changes the expanded output shape and can break output_padding cases.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell