[ET-VK] Make libtorch optional in custom op test binaries#19402
Merged
meta-codesync[bot] merged 1 commit intogh/SS-JIA/529/basefrom May 8, 2026
Merged
[ET-VK] Make libtorch optional in custom op test binaries#19402meta-codesync[bot] merged 1 commit intogh/SS-JIA/529/basefrom
meta-codesync[bot] merged 1 commit intogh/SS-JIA/529/basefrom
Conversation
Add `include_torch` parameter (default False) to `define_custom_op_test_binary()`. None of the custom op test binaries directly include torch/ATen/c10 headers, so libtorch was unnecessary baggage. Dropping it reduces the q4gsw_linear_adreno binary from ~1 GB to 74 MB. Differential Revision: [D104456804](https://our.internmc.facebook.com/intern/diff/D104456804/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19402
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 7debf5c with merge base c564936 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
manuelcandales
approved these changes
May 8, 2026
meta-codesync
Bot
merged commit 7fa51a7
into
gh/SS-JIA/529/base
177 of 183 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add
include_torchparameter (default False) todefine_custom_op_test_binary(). None of the custom op test binariesdirectly include torch/ATen/c10 headers, so libtorch was unnecessary
baggage. Dropping it reduces the q4gsw_linear_adreno binary from ~1 GB
to 74 MB.
Differential Revision: D104456804