Skip to content

[ET-VK] Make libtorch optional in custom op test binaries#19433

Open
pytorchbot wants to merge 1 commit intomainfrom
gh/SS-JIA/529/orig
Open

[ET-VK] Make libtorch optional in custom op test binaries#19433
pytorchbot wants to merge 1 commit intomainfrom
gh/SS-JIA/529/orig

Conversation

@pytorchbot
Copy link
Copy Markdown
Collaborator

@pytorchbot pytorchbot commented May 8, 2026

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #19402 by @SS-JIA
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/529/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/529/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/529/orig
Differential Revision: D104456804
@diff-train-skip-merge

[ET-VK] Make libtorch optional in custom op test binaries
24de0f7 
Add `include_torch` parameter (default False) to
`define_custom_op_test_binary()`. None of the custom op test binaries
directly include torch/ATen/c10 headers, so libtorch was unnecessary
baggage. Dropping it reduces the q4gsw_linear_adreno binary from ~1 GB
to 74 MB.

Differential Revision: [D104456804](https://our.internmc.facebook.com/intern/diff/D104456804/)

ghstack-source-id: 379498992
Pull Request resolved: #19402
@pytorchbot pytorchbot requested a review from SS-JIA as a code owner May 8, 2026 23:26
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 8, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19433

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 1 Pending

As of commit 24de0f7 with merge base c564936 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SS-JIA SS-JIA Awaiting requested review from SS-JIA SS-JIA is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pytorchbot