Fix variable type mismatch build failure#20437
Closed
GregoryComer wants to merge 1 commit into
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20437
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 136 PendingAs of commit 8acc74f with merge base 39c0df6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
GregoryComer
added
the
release notes: none
Gasoonjia
approved these changes
Jun 23, 2026
Member
Author
|
Closing, as this appears to be a local env issue due to multiple torch installs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a variable type mismatch in two locations - it should be uint64_t, not size_t. This appears to be a regression introduced when adding overflow checks. It compiles on some platforms, but breaks on platforms where uint64_t != size_t. For example, on mac w/ clang, size_t is unsigned long whereas uint64_t is unsigned long long. Both are 64 bits, but it nonetheless fails to compile due to the mismatch.