Allow context-binary lowering to use edge dialect ops (#20518)#20518
Open
JakeStevens wants to merge 1 commit into
Open
Allow context-binary lowering to use edge dialect ops (#20518)#20518JakeStevens wants to merge 1 commit into
JakeStevens wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20518
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit 9daf0b4 with merge base f8c8334 ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109598309. |
This PR needs a
|
meta-codesync
Bot
changed the title
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Jun 25, 2026
Summary: Unblocks the QNN context-binary path from lowering through `to_edge` with `_use_edge_ops=True` (the default). Previously it was pinned to `EdgeCompileConfig(_use_edge_ops=False)` purely to keep the `qaisw` context-loader custom op's original name, because loader detection was name-based. Loader detection now goes through a single `is_context_loader_target()` helper that matches the op namespace (so it works on the edge-dialect wrapper), replacing the three name-dependent checks (`eval`, raw `.namespace`, substring). Differential Revision: D109598309
JakeStevens
force-pushed
the
export-D109598309
branch
from
ce774b0 to
101ea39
Compare
JakeStevens
added
the
module: qnn
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Jun 25, 2026
Summary: Unblocks the QNN context-binary path from lowering through `to_edge` with `_use_edge_ops=True` (the default). Previously it was pinned to `EdgeCompileConfig(_use_edge_ops=False)` purely to keep the `qaisw` context-loader custom op's original name, because loader detection was name-based. Loader detection now goes through a single `is_context_loader_target()` helper that matches the op namespace (so it works on the edge-dialect wrapper), replacing the three name-dependent checks (`eval`, raw `.namespace`, substring). Differential Revision: D109598309
JakeStevens
force-pushed
the
export-D109598309
branch
from
101ea39 to
e924d07
Compare
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Jul 6, 2026
Summary: Unblocks the QNN context-binary path from lowering through `to_edge` with `_use_edge_ops=True` (the default). Previously it was pinned to `EdgeCompileConfig(_use_edge_ops=False)` purely to keep the `qaisw` context-loader custom op's original name, because loader detection was name-based. Loader detection now goes through a single `is_context_loader_target()` helper that matches the op namespace (so it works on the edge-dialect wrapper), replacing the three name-dependent checks (`eval`, raw `.namespace`, substring). Differential Revision: D109598309
JakeStevens
force-pushed
the
export-D109598309
branch
from
e924d07 to
1095873
Compare
psiddh
requested review from
chenweng-quic,
haowhsu-quic,
shewu-quic and
winskuo-quic
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Jul 7, 2026
Summary: Unblocks the QNN context-binary path from lowering through `to_edge` with `_use_edge_ops=True` (the default). Previously it was pinned to `EdgeCompileConfig(_use_edge_ops=False)` purely to keep the `qaisw` context-loader custom op's original name, because loader detection was name-based. Loader detection now goes through a single `is_context_loader_target()` helper that matches the op namespace (so it works on the edge-dialect wrapper), replacing the three name-dependent checks (`eval`, raw `.namespace`, substring). Differential Revision: D109598309
JakeStevens
force-pushed
the
export-D109598309
branch
from
1095873 to
18d165e
Compare
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Jul 7, 2026
Summary: Unblocks the QNN context-binary path from lowering through `to_edge` with `_use_edge_ops=True` (the default). Previously it was pinned to `EdgeCompileConfig(_use_edge_ops=False)` purely to keep the `qaisw` context-loader custom op's original name, because loader detection was name-based. Loader detection now goes through a single `is_context_loader_target()` helper that matches the op namespace (so it works on the edge-dialect wrapper), replacing the three name-dependent checks (`eval`, raw `.namespace`, substring). Differential Revision: D109598309
JakeStevens
force-pushed
the
export-D109598309
branch
from
18d165e to
36aeffe
Compare
Summary: Unblocks the QNN context-binary path from lowering through `to_edge` with `_use_edge_ops=True` (the default). Previously it was pinned to `EdgeCompileConfig(_use_edge_ops=False)` purely to keep the `qaisw` context-loader custom op's original name, because loader detection was name-based. Loader detection now goes through a single `is_context_loader_target()` helper that matches the op namespace (so it works on the edge-dialect wrapper), replacing the three name-dependent checks (`eval`, raw `.namespace`, substring). Differential Revision: D109598309
JakeStevens
force-pushed
the
export-D109598309
branch
from
36aeffe to
9daf0b4
Compare
shewu-quic
reviewed
Jul 9, 2026
| op = unwrap_op_overload(target) | ||
| if op.namespace != OpContextLoader.namespace: | ||
| return False | ||
| if op_name is None: |
Collaborator
There was a problem hiding this comment.
Why does op_name is None evaluate as True?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Unblocks the QNN context-binary path from lowering through
to_edgewith_use_edge_ops=True(the default). Previously it was pinned toEdgeCompileConfig(_use_edge_ops=False)purely to keep theqaiswcontext-loader custom op's original name, because loader detection was name-based.Loader detection now goes through a single
is_context_loader_target()helper that matches the op namespace (so it works on the edge-dialect wrapper), replacing the three name-dependent checks (eval, raw.namespace, substring).Differential Revision: D109598309