NXP Backend: enable CPPCHECK for NXP backend and example#20593
Merged
robert-kalmar merged 2 commits intoJul 1, 2026
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20593
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 7a1a471 with merge base 6021a58 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
|
robert-kalmar
added
module: nxp
Collaborator
Author
|
@irtrukhina please add yourself to reviewers too. For some reason cannot find you. |
rascani
approved these changes
Jun 29, 2026
MartinPavella
approved these changes
Jun 30, 2026
Signed-off-by: Robert Kalmar <robert.kalmar@nxp.com>
Fixes: - report error on STDERR, - do not call exit() in function - use C++ import style for C headers. Signed-off-by: Robert Kalmar <robert.kalmar@nxp.com>
robert-kalmar
force-pushed
the
feature/EIEX-982-enable-cppcheck-for-nxp-code
branch
from
81e6380 to
7a1a471
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable CPPCHECK for NXP Backend and fix initial findings.
Additional fixes in
nxp_executor_runner:- report error on STDERR,
- do not call exit() in function
- use C++ import style for C headers.
Test plan
Existing unit test covering.
cc @JakeStevens @digantdesai @rascani