Add missing Buck deps for TOSA dialect real_impl#20642
Conversation
Summary: Adds the two missing third-party Buck deps to the `//executorch/backends/arm/tosa/dialect:core` target so the Arm TOSA dialect imports under Buck again. This is a stacked follow-up fix for D110150349. D110150349 added `real_impl.py` to the `srcs` of the `core` target. `real_impl.py` imports `tosa_reference_model` and `tosa_serializer` at module top level, but the target `deps` were not updated to provide them. Because `ops_registration.py` now imports `real_impl` unconditionally, and every TOSA op module imports from `ops_registration`, the entire Arm TOSA dialect fails to import under Buck. This cascades into every downstream consumer that touches the Arm lowering path. The import works in OSS (where the deps come from pip/CMake) but breaks under Buck, where third-party deps must be declared explicitly. The fix adds them to the `core` target: - `fbsource//third-party/tosa_tools:serializer` - `fbsource//third-party/tosa_tools:tosa_reference_model` Differential Revision: D110214945
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20642
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2968db8 with merge base e095c57 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
|
@rascani has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110214945. |
This PR needs a
|
…-land)" (#20670) Reverts #20537 This breaks some internal tests due to missing BUCK dependencies on the tosa reference model. I tried to fix forward by just adding those deps (#20642), but it looks like we'll need to do lazy imports here due to some binary size expansion. I'll tackle the reland. cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell
2 participants
Summary:
Adds the two missing third-party Buck deps to the
//executorch/backends/arm/tosa/dialect:coretarget so the Arm TOSA dialect imports under Buck again. This is a stacked follow-up fix for D110150349.D110150349 added
real_impl.pyto thesrcsof thecoretarget.real_impl.pyimportstosa_reference_modelandtosa_serializerat module top level, but the targetdepswere not updated to provide them. Becauseops_registration.pynow importsreal_implunconditionally, and every TOSA op module imports fromops_registration, the entire Arm TOSA dialect fails to import under Buck. This cascades into every downstream consumer that touches the Arm lowering path.The import works in OSS (where the deps come from pip/CMake) but breaks under Buck, where third-party deps must be declared explicitly. The fix adds them to the
coretarget:fbsource//third-party/tosa_tools:serializerfbsource//third-party/tosa_tools:tosa_reference_modelDifferential Revision: D110214945
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell