Skip to content

[ExecuTorch][Vulkan] Tests for et_vk.q4gsw_requant#20946

Open
JCNTH wants to merge 11 commits into
gh/JCNTH/85/basefrom
gh/JCNTH/85/head
Open

[ExecuTorch][Vulkan] Tests for et_vk.q4gsw_requant#20946
JCNTH wants to merge 11 commits into
gh/JCNTH/85/basefrom
gh/JCNTH/85/head

Conversation

@JCNTH

@JCNTH JCNTH commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Correctness tests for the Vulkan et_vk.q4gsw_requant kernel (stacked above the op diff).

Coverage: the golden codes are computed with ATen (round/clamp, zero-scale -> code 8), mirroring quant_nibble, then packed into the expected W_4X8 int buffer with a small bit-packing reference (data-reshaping only, no hand-rolled math). The kernel output is compared int-for-int against that buffer, which locks the exact byte layout the forward reads. The latent is built as code * scale so round() is unambiguous (no .5 tie-break divergence).

Cases:

  • test_tile_aligned — single group, tile-aligned N/K.
  • test_grouped — multiple quantization groups along K.
  • test_odd_n4N % 8 != 0 (odd N4 -> padded stride + bias-zero OOB tile).
  • test_zero_scale — a zero scale must yield code 8, not a divide-by-zero.

Also wires q4gsw_requant_test into targets.bzl + CMakeLists.txt.
@exported-using-ghexport

Differential Revision: D111797526

Differential Revision: D111797526

[ghstack-poisoned]
@pytorch-bot pytorch-bot Bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Jul 14, 2026
@pytorch-bot

pytorch-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20946

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jul 14, 2026
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]

@SS-JIA SS-JIA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@JCNTH
JCNTH requested a deployment to cadence July 21, 2026 06:49 — with GitHub Actions Pending
@JCNTH
JCNTH requested a deployment to cadence July 21, 2026 06:49 — with GitHub Actions Pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants