Skip to content

Remove unused using-declarations#20953

Merged
rascani merged 1 commit into
pytorch:mainfrom
cyyever:remove-unused-using
Jul 16, 2026
Merged

Remove unused using-declarations#20953
rascani merged 1 commit into
pytorch:mainfrom
cyyever:remove-unused-using

Conversation

@cyyever

@cyyever cyyever commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Delete using-declarations whose name is never used in the file (384 across 218 .cpp/.mm files, found by scripted scan). Deletion only — no call sites changed. Using-declarations in headers are left alone since includers may rely on them.

Authored with Claude Code.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

@pytorch-bot

pytorch-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20953

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Awaiting Approval, 1 New Failure

As of commit 40902e2 with merge base e16c048 (image):

AWAITING APPROVAL - The following workflow needs approval before CI can run:

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 15, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Jul 15, 2026
@pytorch-bot

pytorch-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

Workflows were awaiting approval. CI has now been triggered for the ciflow labels on this PR.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@rascani

rascani commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Thanks for doing this @cyyever!

It looks like a pybind submodule update snuck into the commit, I assume that was unintentional?

@cyyever
cyyever force-pushed the remove-unused-using branch from 161a081 to 5fbdd00 Compare July 16, 2026 00:46
@cyyever

cyyever commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

@rascani That was unintentional commit, restored it.

Signed-off-by: cyy <cyyever@outlook.com>
@cyyever
cyyever force-pushed the remove-unused-using branch from 5fbdd00 to 40902e2 Compare July 16, 2026 00:51
@rascani
rascani merged commit 96c83ed into pytorch:main Jul 16, 2026
541 of 543 checks passed
@cyyever
cyyever deleted the remove-unused-using branch July 16, 2026 23:57
@nil-is-all nil-is-all added enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: cleanup Issues/PRs which cleanup code across the repository and removed module: arm Issues related to arm backend labels Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: cleanup Issues/PRs which cleanup code across the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants