Skip to content

Fix printf format specifier mismatches#21034

Open
cyyever wants to merge 2 commits into
pytorch:mainfrom
cyyever:fix-format-strings
Open

Fix printf format specifier mismatches#21034
cyyever wants to merge 2 commits into
pytorch:mainfrom
cyyever:fix-format-strings

Conversation

@cyyever

@cyyever cyyever commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Fix sign/size mismatches in ET_LOG/ET_CHECK format strings (PRIu64 for int64_t, %zd for size_t, %ld for int32_t/size_t, %u for signed) and malformed literals like 0x%x" PRIx32 that printed a stray character. Found via clang -Wformat=2 build plus a signedness audit; every fix verified against the argument's declared type, and the compiled surface rebuilds warning-free.

Authored with Claude.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

@pytorch-bot

pytorch-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21034

Note: Links to docs will display an error until the docs builds have been completed.

⚠️ 17 Awaiting Approval

As of commit 7d36e17 with merge base 5c9cd91 (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Jul 18, 2026
@pytorch-bot

pytorch-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown

The following ciflow label(s) have been added but CI has not been triggered yet because the workflows are awaiting approval:

  • ciflow/trunk

Once a maintainer approves the workflows (scroll to the bottom of the PR page), the corresponding CI jobs will be triggered automatically. Please ping one of the reviewers if you do not have access to approve and run workflows.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant