[ET-VK] Simplify lane offset copy logic in copy_packed_dim_offset shader.#9416
Merged
facebook-github-bot merged 5 commits intogh/trivedivivek/69/basefrom Apr 1, 2025
Merged
Conversation
…der. This diff simplifies the logic for handling different lane offsets in `copy_packed_dim_offset` shader. Differential Revision: [D71507929](https://our.internmc.facebook.com/intern/diff/D71507929/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9416
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5af593c with merge base feb3fcd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Mar 19, 2025
trviv
added a commit
that referenced
this pull request
Mar 19, 2025
…der. This diff simplifies the logic for handling different lane offsets in `copy_packed_dim_offset` shader. Differential Revision: [D71507929](https://our.internmc.facebook.com/intern/diff/D71507929/) ghstack-source-id: 272850534 Pull Request resolved: #9416
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71507929 |
yipjustin
approved these changes
Mar 21, 2025
…_offset shader." This diff simplifies the logic for handling different lane offsets in `copy_packed_dim_offset` shader. Differential Revision: [D71507929](https://our.internmc.facebook.com/intern/diff/D71507929/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71507929 |
…_offset shader." This diff simplifies the logic for handling different lane offsets in `copy_packed_dim_offset` shader. Differential Revision: [D71507929](https://our.internmc.facebook.com/intern/diff/D71507929/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71507929 |
…_offset shader." This diff simplifies the logic for handling different lane offsets in `copy_packed_dim_offset` shader. Differential Revision: [D71507929](https://our.internmc.facebook.com/intern/diff/D71507929/) [ghstack-poisoned]
trviv
added a commit
that referenced
this pull request
Apr 1, 2025
…der. Pull Request resolved: #9416 This diff simplifies the logic for handling different lane offsets in `copy_packed_dim_offset` shader. ghstack-source-id: 275286119 @exported-using-ghexport Differential Revision: [D71507929](https://our.internmc.facebook.com/intern/diff/D71507929/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71507929 |
…_offset shader." This diff simplifies the logic for handling different lane offsets in `copy_packed_dim_offset` shader. Differential Revision: [D71507929](https://our.internmc.facebook.com/intern/diff/D71507929/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71507929 |
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff simplifies the logic for handling different lane offsets in
copy_packed_dim_offsetshader.Differential Revision: D71507929