[ET-VK] Replace Uniform buffers with push constants for native layer norm op#9831
Merged
facebook-github-bot merged 2 commits intogh/trivedivivek/73/basefrom Apr 3, 2025
Merged
Conversation
…norm op This diff replaces Uniform buffers with push constants for the native layer norm op in the Vulkan backend of Executorch. The changes include updating the shader code to use push constants instead of Uniform buffers, and updating the C++ code to pass the sizes as push constants to the shader. Differential Revision: [D70943355](https://our.internmc.facebook.com/intern/diff/D70943355/) [ghstack-poisoned]
This was referenced Apr 2, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9831
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3767208 with merge base cc73d03 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
trviv
added a commit
that referenced
this pull request
Apr 2, 2025
…norm op This diff replaces Uniform buffers with push constants for the native layer norm op in the Vulkan backend of Executorch. The changes include updating the shader code to use push constants instead of Uniform buffers, and updating the C++ code to pass the sizes as push constants to the shader. Differential Revision: [D70943355](https://our.internmc.facebook.com/intern/diff/D70943355/) ghstack-source-id: 275545460 Pull Request resolved: #9831
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70943355 |
nathanaelsee
approved these changes
Apr 2, 2025
…tive layer norm op" This diff replaces Uniform buffers with push constants for the native layer norm op in the Vulkan backend of Executorch. The changes include updating the shader code to use push constants instead of Uniform buffers, and updating the C++ code to pass the sizes as push constants to the shader. Differential Revision: [D70943355](https://our.internmc.facebook.com/intern/diff/D70943355/) [ghstack-poisoned]
trviv
added a commit
that referenced
this pull request
Apr 3, 2025
…norm op Pull Request resolved: #9831 This diff replaces Uniform buffers with push constants for the native layer norm op in the Vulkan backend of Executorch. The changes include updating the shader code to use push constants instead of Uniform buffers, and updating the C++ code to pass the sizes as push constants to the shader. Differential Revision: [D70943355](https://our.internmc.facebook.com/intern/diff/D70943355/) ghstack-source-id: 275813550
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70943355 |
facebook-github-bot
merged commit cabc832
into
gh/trivedivivek/73/base
84 of 86 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
trviv
added a commit
that referenced
this pull request
Apr 3, 2025
…norm op (#9872) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #9831 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/73/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/73/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/72/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/73/orig @diff-train-skip-merge --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
…norm op (#9872) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #9831 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/73/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/73/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/72/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/73/orig @diff-train-skip-merge --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
This was referenced Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff replaces Uniform buffers with push constants for the native layer norm op in the Vulkan backend of Executorch. The changes include updating the shader code to use push constants instead of Uniform buffers, and updating the C++ code to pass the sizes as push constants to the shader.
Differential Revision: D70943355