Modernize code

Signed-off-by: cyy <cyyever@outlook.com>

Author: cyyever

gloo/algorithm.cc

@@ -21,7 +21,7 @@ Algorithm::Algorithm(const std::shared_ptr<Context>& context)
       contextSize_(context_->size) {}
 
 // Have to provide implementation for pure virtual destructor.
-Algorithm::~Algorithm() noexcept(false) {}
+Algorithm::~Algorithm() noexcept(false) = default;
 
 std::unique_ptr<transport::Pair>& Algorithm::getPair(int i) {
   return context_->getPair(i);

gloo/algorithm.h

@@ -100,7 +100,7 @@ const ReductionFunction<T>* ReductionFunction<T>::max =
 template <typename T>
 class LocalOp {
  public:
-  virtual ~LocalOp() noexcept(false) {}
+  virtual ~LocalOp() noexcept(false) = default;
   virtual void runAsync() = 0;
   virtual void wait() = 0;
 

gloo/allgather_ring.h

@@ -52,9 +52,9 @@ class AllgatherRing : public Algorithm {
         rightPair_->createRecvBuffer(notificationSlot, &dummy_, sizeof(dummy_));
   }
 
-  virtual ~AllgatherRing() {}
+  ~AllgatherRing() override = default;
 
-  void run() {
+  void run() override {
     // Short circuit if there is only a single process or the output is empty.
     if (this->contextSize_ == 1 || count_ == 0) {
       return;

gloo/allreduce.cc

@@ -110,11 +110,11 @@ void allreduce(const detail::AllreduceOptionsImpl& opts) {
 
   // Assert the size of all inputs and outputs is identical.
   const size_t totalBytes = opts.elements * opts.elementSize;
-  for (size_t i = 0; i < out.size(); i++) {
-    GLOO_ENFORCE_EQ(out[i]->size, totalBytes);
+  for (const auto& i : out) {
+    GLOO_ENFORCE_EQ(i->size, totalBytes);
   }
-  for (size_t i = 0; i < in.size(); i++) {
-    GLOO_ENFORCE_EQ(in[i]->size, totalBytes);
+  for (const auto& i : in) {
+    GLOO_ENFORCE_EQ(i->size, totalBytes);
   }
 
   // Initialize local reduction and broadcast functions.
@@ -560,8 +560,7 @@ void bcube(
     }
 
     // Wait for send and receive operations to complete.
-    for (size_t i = 0; i < group.ranks.size(); i++) {
-      const auto peer = group.ranks[i];
+    for (unsigned long peer : group.ranks) {
       if (peer == context->rank) {
         continue;
       }
@@ -640,8 +639,7 @@ void bcube(
     }
 
     // Wait for operations to complete.
-    for (size_t i = 0; i < group.ranks.size(); i++) {
-      const auto peer = group.ranks[i];
+    for (unsigned long peer : group.ranks) {
       if (peer == context->rank) {
         continue;
       }

gloo/allreduce.h

@@ -42,17 +42,15 @@ struct AllreduceOptionsImpl {
   };
 
   explicit AllreduceOptionsImpl(const std::shared_ptr<Context>& context)
-      : context(context),
-        timeout(context->getTimeout()),
-        algorithm(UNSPECIFIED) {}
+      : context(context), timeout(context->getTimeout()) {}
 
   std::shared_ptr<Context> context;
 
   // End-to-end timeout for this operation.
   std::chrono::milliseconds timeout;
 
   // Algorithm selection.
-  Algorithm algorithm;
+  Algorithm algorithm{UNSPECIFIED};
 
   // Input and output buffers.
   // The output is used as input if input is not specified.

gloo/allreduce_bcube.h

@@ -345,7 +345,7 @@ class AllreduceBcube : public Algorithm {
 #define DEBUG_PRINT_RECV(stage)
 #endif
 
-  void run() {
+  void run() override {
     if (totalNumElems_ == 0) {
       return;
     }

gloo/allreduce_halving_doubling.h

@@ -82,14 +82,7 @@ class AllreduceHalvingDoubling : public Algorithm {
         sendOffsets_(steps_),
         recvOffsets_(steps_),
         sendCounts_(steps_, 0),
-        recvCounts_(steps_, 0),
-        sendCountToLargerBlock_(0),
-        offsetToMyBinaryBlock_(0),
-        myBinaryBlockSize_(0),
-        stepsWithinBlock_(0),
-        rankInBinaryBlock_(0),
-        nextSmallerBlockSize_(0),
-        nextLargerBlockSize_(0) {
+        recvCounts_(steps_, 0) {
     if (count_ == 0 || this->contextSize_ == 1) {
       return;
     }
@@ -222,7 +215,7 @@ class AllreduceHalvingDoubling : public Algorithm {
     }
   }
 
-  void run() {
+  void run() override {
     if (count_ == 0) {
       return;
     }
@@ -394,7 +387,7 @@ class AllreduceHalvingDoubling : public Algorithm {
 
   std::vector<size_t> sendCounts_;
   std::vector<size_t> recvCounts_;
-  size_t sendCountToLargerBlock_;
+  size_t sendCountToLargerBlock_{0};
 
   int dummy_;
   std::vector<std::unique_ptr<transport::Buffer>> sendNotificationBufs_;
@@ -404,12 +397,12 @@ class AllreduceHalvingDoubling : public Algorithm {
   // binary blocks and keep track of which block each process is in, as well as
   // the adjoining larger and smaller blocks (with which communication will be
   // required)
-  uint32_t offsetToMyBinaryBlock_;
-  uint32_t myBinaryBlockSize_;
-  uint32_t stepsWithinBlock_;
-  uint32_t rankInBinaryBlock_;
-  uint32_t nextSmallerBlockSize_;
-  uint32_t nextLargerBlockSize_;
+  uint32_t offsetToMyBinaryBlock_{0};
+  uint32_t myBinaryBlockSize_{0};
+  uint32_t stepsWithinBlock_{0};
+  uint32_t rankInBinaryBlock_{0};
+  uint32_t nextSmallerBlockSize_{0};
+  uint32_t nextLargerBlockSize_{0};
 
   int slotOffset_;
 };

gloo/allreduce_local.cc

@@ -8,7 +8,7 @@
 
 #include "gloo/allreduce_local.h"
 
-#include <string.h>
+#include <cstring>
 
 namespace gloo {
 

gloo/allreduce_local.h

@@ -22,9 +22,9 @@ class AllreduceLocal : public Algorithm {
       const int count,
       const ReductionFunction<T>* fn = ReductionFunction<T>::sum);
 
-  virtual ~AllreduceLocal() = default;
+  ~AllreduceLocal() override = default;
 
-  virtual void run() override;
+  void run() override;
 
  protected:
   std::vector<T*> ptrs_;

gloo/allreduce_ring.h

@@ -57,7 +57,7 @@ class AllreduceRing : public Algorithm {
         rightPair->createRecvBuffer(notificationSlot, &dummy_, sizeof(dummy_));
   }
 
-  virtual ~AllreduceRing() {
+  ~AllreduceRing() override {
     if (inbox_ != nullptr) {
       free(inbox_);
     }
@@ -66,7 +66,7 @@ class AllreduceRing : public Algorithm {
     }
   }
 
-  void run() {
+  void run() override {
     if (count_ == 0) {
       return;
     }