[Pallas] Implement indirect gather via exact one-hot matmul#2035
Closed
thcmbs wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
thcmbs
force-pushed
the
pallas-copy3d-gather
branch
5 times, most recently
from
b50d87c to
1e43767
Compare
thcmbs
force-pushed
the
pallas-copy3d-gather
branch
from
91e3aec to
eb00094
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pallas lacks native gather instructions. This PR implements indirect gather (
tensor[idx]) by lowering to a one-hot matrix multiplication.one_hot(idx, V) @ table.float32withPrecision.HIGHESTto prevent MXU truncation errors during accumulation.