[runtime:pallas] migrate to torch_tpu's new Pallas buffer donation API#2351
Open
cota wants to merge 2 commits into
Open
[runtime:pallas] migrate to torch_tpu's new Pallas buffer donation API#2351cota wants to merge 2 commits into
cota wants to merge 2 commits into
Conversation
This is a non-functional change that reduces code duplication.
`input_output_aliases` will go away. Instead, implement aliasing by using `donate_argnums` (which is now strictly for donation) and explicitly copying back results via `copy_()`.
meta-cla
Bot
added
the
CLA Signed
oulgen
reviewed
May 7, 2026
Contributor
oulgen
left a comment
oulgen
left a comment
There was a problem hiding this comment.
explicitly copying back results via
copy_()
Isn't this very inefficient?
Collaborator
Author
|
Yes. As discussed on chat, the idea is to get off the deprecated API first, then optimize. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
input_output_aliaseswill go away. Instead, implement aliasing by usingdonate_argnums(which is now strictly for donation) and explicitly copying back results viacopy_().