Merge branch 'master' into final-clean-handler-3563

Author: leelakrishnaRajasimha

examples/mnist/mnist_with_neptune_logger.py

@@ -11,11 +11,6 @@
     python mnist_with_neptune_logger.py
     ```
 
-    Go to https://neptune.ai and explore your run.
-
-Note:
-    You can view example runs here:
-    https://app.neptune.ai/o/common/org/pytorch-ignite-integration/
 """
 
 from argparse import ArgumentParser

ignite/handlers/neptune_logger.py

@@ -35,15 +35,15 @@
 
 class NeptuneLogger(BaseLogger):
     """
-    `Neptune <https://neptune.ai/>`_ handler to log metrics, model/optimizer parameters and gradients during training
+    Neptune handler to log metrics, model/optimizer parameters and gradients during training
     and validation. It can also log model checkpoints to Neptune.
 
     .. code-block:: bash
 
         pip install neptune
 
     Args:
-        api_token: Neptune API token, found on https://neptune.ai -> User menu -> "Get your API token".
+        api_token: Neptune API token, found on the Neptune user menu -> "Get your API token".
            If None, the value of the NEPTUNE_API_TOKEN environment variable is used. To keep your token
            secure, you should set it to the environment variable rather than including it in your code.
         project: Name of a Neptune project, in the form "workspace-name/project-name".
@@ -113,9 +113,6 @@ class NeptuneLogger(BaseLogger):
                 log_handler=WeightsScalarHandler(model),
             )
 
-        Explore runs with Neptune tracking here:
-        https://app.neptune.ai/o/common/org/pytorch-ignite-integration/
-
         You can also save model checkpoints to a Neptune:
 
         .. code-block:: python
@@ -662,9 +659,6 @@ def score_function(engine):
             # We need to close the logger when we are done
             npt_logger.close()
 
-    For example, you can access model checkpoints and download them from here:
-    https://app.neptune.ai/o/shared/org/pytorch-ignite-integration/e/PYTOR1-18/charts
-
     """
 
     @idist.one_rank_only()

tests/ignite/distributed/test_launcher.py

@@ -48,11 +48,14 @@ def execute(cmd, env=None):
     env = dict(os.environ) if env is None else env
     env["PYTHONPATH"] = f"{os.path.dirname(ignite.__path__[0])}"
     process = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, env=env)
-    process.wait()
+    stdout, stderr = process.communicate()
+    stdout_str = stdout.decode("utf-8", errors="replace") if stdout else ""
+    stderr_str = stderr.decode("utf-8", errors="replace") if stderr else ""
+
     if process.returncode != 0:
-        print(str(process.stdout.read()) + str(process.stderr.read()))
-        raise subprocess.CalledProcessError(returncode=process.returncode, cmd=cmd, stderr=process.stderr.read())
-    return str(process.stdout.read()) + str(process.stderr.read())
+        print(stdout_str + stderr_str)
+        raise subprocess.CalledProcessError(returncode=process.returncode, cmd=cmd, stderr=stderr_str)
+    return stdout_str + stderr_str
 
 
 @pytest.mark.skipif(not is_mps_available_and_functional(), reason="Skip if MPS not functional")