Skip to content

Commit aff62c9

Browse files
committed
Improved dynamic forwarding
1 parent 1358b72 commit aff62c9

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

ignite/distributed/comp_models/native.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,13 @@ def _create_from_backend(
149149
init_pg_kwargs["world_size"] = int(os.environ["WORLD_SIZE"]) if world_size is None else world_size
150150
init_pg_kwargs["rank"] = int(os.environ["RANK"]) if rank is None else rank
151151

152-
# forward any remaining kwargs to support custom arguments like pg_options, etc.
153-
init_pg_kwargs.update(kwargs)
152+
# Only forward kwargs that are valid parameters of dist.init_process_group
153+
import inspect
154+
155+
sig = inspect.signature(dist.init_process_group)
156+
for key, val in kwargs.items():
157+
if key in sig.parameters:
158+
init_pg_kwargs[key] = val
154159

155160
dist.init_process_group(backend, init_method=init_method, **init_pg_kwargs)
156161

0 commit comments

Comments
 (0)