Skip to content

[BugFix] Fix SliceSampler for torch.compile compatibility#3298

Merged
vmoens merged 5 commits into
gh/vmoens/179/basefrom
gh/vmoens/179/head
Jun 8, 2026
Merged

[BugFix] Fix SliceSampler for torch.compile compatibility#3298
vmoens merged 5 commits into
gh/vmoens/179/basefrom
gh/vmoens/179/head

Conversation

@vmoens

@vmoens vmoens commented Jan 8, 2026

Copy link
Copy Markdown
Collaborator

Stack from ghstack (oldest at bottom):

Convert seq_length to tensor before torch.where operations to avoid
torch.compile inductor C++ codegen bugs with mixed scalar/tensor int64
in blendv operations.

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Jan 8, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3298

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 1 Unrelated Failure

As of commit 9415b1d with merge base d7ef78b (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vmoens added 4 commits January 8, 2026 08:42
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Jun 8, 2026
Convert seq_length to tensor before torch.where operations to avoid
torch.compile inductor C++ codegen bugs with mixed scalar/tensor int64
in blendv operations.


ghstack-source-id: 8e546ee
Pull-Request: #3298
@vmoens vmoens merged commit 9415b1d into gh/vmoens/179/base Jun 8, 2026
109 of 110 checks passed
@vmoens vmoens deleted the gh/vmoens/179/head branch June 8, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BugFix CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. ReplayBuffers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant