[CRCR] Add CRCR results to main HUD grid with monsterization#8285
Open
subinz1 wants to merge 1 commit into
Open
[CRCR] Add CRCR results to main HUD grid with monsterization#8285subinz1 wants to merge 1 commit into
subinz1 wants to merge 1 commit into
Conversation
|
@subinz1 is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
Bot
added
the
CLA Signed
subinz1
force-pushed
the
crcr-hud-grid-monsterize
branch
from
0642f92 to
2ee566c
Compare
Integrates CRCR downstream CI results (L2/L3) into the main HUD commit grid as native columns. CRCR jobs appear under a "CRCR" group alongside existing groups (Linux, Windows, etc.) and support all existing HUD features: grouped view, hide-green, hide-always-skipped, job filter, tooltips, and monsterization. The approach mirrors the AI advisor verdicts pattern — a parallel ClickHouse query fetches CRCR results by SHA, maps them into JobData, and merges them into each row's nameToJobs before grouping runs. This means zero new UI components; existing JobCell, HudGroupedCell, and JobConclusion handle rendering and monsterization automatically. For monsterization, failed CRCR jobs use failed_tests_json (when available) or a synthetic string (downstream_repo/job_name) as the failure line hash input, giving each unique failure type its own monster sprite. Authored with an AI assistant.
subinz1
force-pushed
the
crcr-hud-grid-monsterize
branch
from
2ee566c to
c65fbdf
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates CRCR downstream CI results into the main HUD commit grid (
hud.pytorch.org) as native columns with full monsterization support.pytorch/pytorch— no impact on other reposMockup
Main HUD grid mockup with CRCR columns
Approach
Mirrors the AI advisor verdicts pattern:
crcr_hud_results) fetches CRCR results by commit SHAuseClickHouseAPIImmutable(no changes tofetchHud)JobDataand merges into each row'snameToJobsbefore groupingJobCell,HudGroupedCell, andJobConclusionhandle everythingLevel-based filtering
Column names include the CRCR level — e.g.
CRCR pytorch/crcr-test / l1-critical (L3). This integrates with the existing "Hide non-viable-strict jobs" filter:L4 CRCR jobs are registered as viable/strict blocking via the
(L4)pattern inVIABLE_STRICT_BLOCKING_JOBS.Monsterization
Failed CRCR jobs produce monster sprites by hashing:
failed_tests_jsoncontent (when available from downstream test reports)downstream_repo/job_name(fallback — gives each unique CRCR failure type its own monster)Files changed
clickhouse_queries/crcr_hud_results/lib/JobClassifierUtil.ts(L4)as viable/strict blockingpages/hud/.../[[...page]].tsxTest plan
hud.pytorch.org/hud/pytorch/pytorch/main