Skip to content

Commit cdc645a

Browse files
jiannanWangsekyondaMetaAlannaBurke
authored
Remove deprecated TensorBoard profiler tutorial (#3813)
Fixes pytorch/kineto#1340 step 2. ## Description Remove the tensorboard_profiler_tutorial.py tutorial and all associated files, as the TensorBoard integration with the PyTorch profiler is deprecated and under removal. Changes: - Delete intermediate_source/tensorboard_profiler_tutorial.py - Remove 16 profiler images only used by this tutorial - Remove references from index.rst, ecosystem.rst, .lintrunner.toml, .jenkins/validate_tutorials_built.py, and .jenkins/build.sh ## Checklist <!--- Make sure to add `x` to all items in the following checklist: --> - [x] The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER") - [x] Only one issue is addressed in this pull request - [x] Labels from the issue that this PR is fixing are added to this pull request - [x] No unnecessary issues are included into this pull request. Co-authored-by: sekyondaMeta <127536312+sekyondaMeta@users.noreply.github.com> Co-authored-by: Alanna Burke <burkealanna@meta.com>
1 parent 45a5b17 commit cdc645a

22 files changed

Lines changed: 0 additions & 529 deletions

.jenkins/build.sh

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,6 @@ if [[ "${JOB_TYPE}" == "worker" ]]; then
5858
# TODO: Fix bugs in these tutorials to make them runnable again
5959
# python $DIR/remove_runnable_code.py beginner_source/audio_classifier_tutorial.py beginner_source/audio_classifier_tutorial.py || true
6060

61-
# Remove runnable code from tensorboard_profiler_tutorial.py as it frequently crashes, see https://github.com/pytorch/pytorch/issues/74139
62-
# python $DIR/remove_runnable_code.py intermediate_source/tensorboard_profiler_tutorial.py intermediate_source/tensorboard_profiler_tutorial.py || true
63-
6461
# Step 2: Keep certain tutorials based on file count, and remove runnable code in all other tutorials
6562
# IMPORTANT NOTE: We assume that each tutorial has a UNIQUE filename.
6663
FILES_TO_RUN=$(python .jenkins/get_files_to_run.py)

.jenkins/validate_tutorials_built.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
"recipes_source/recipes/timer_quick_start",
3737
"recipes_source/recipes/amp_recipe",
3838
"recipes_source/recipes/Captum_Recipe",
39-
"intermediate_source/tensorboard_profiler_tutorial", # reenable after 2.0 release.
4039
"advanced_source/semi_structured_sparse", # reenable after 3303 is fixed.
4140
"intermediate_source/torchrec_intro_tutorial.py", #failing with 2.8 reenable after 3498
4241
"beginner_source/mosaic_memory_profiling_tutorial.py", # failing with 2.11 issue #3774

.lintrunner.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ exclude_patterns = [
6161
"intermediate_source/per_sample_grads.py",
6262
"intermediate_source/pruning_tutorial.py",
6363
"intermediate_source/reinforcement_q_learning.py",
64-
"intermediate_source/tensorboard_profiler_tutorial.py",
6564
"intermediate_source/torch_compile_tutorial.py",
6665
"intermediate_source/transformer_building_blocks.py",
6766
"unstable_source/README.md",

_static/img/profiler_callstack.png

-99.5 KB
Binary file not shown.
-87.1 KB
Binary file not shown.
-88.4 KB
Binary file not shown.
-19.5 KB
Binary file not shown.
-55.3 KB
Binary file not shown.
-124 KB
Binary file not shown.
-126 KB
Binary file not shown.

0 commit comments

Comments
 (0)