docs: Fix incorrect usage description of ctx.save_for_backward#3377
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3377
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @harshaljanjani! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
I’ve signed the Facebook CLA. I believe re-running the tests should reflect that. Thank you very much! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@jbschlosser or @albanD Does this look good? cc: @svekars |
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
albanD
left a comment
There was a problem hiding this comment.
Sounds ok, you can also link https://docs.pytorch.org/docs/stable/notes/extending.html#extending-torch-autograd for further details.
|
@albanD @svekars @sekyondaMeta |
→ Fixes #2797
Description
→ This PR corrects the misleading explanation of
ctx.save_for_backwardin thetwo_layer_net_custom_function.pytutorial. The original text incorrectly stated that arbitrary objects can be cached usingctx.save_for_backward, whereas only tensors are supported.→ The updated docstring now accurately reflects PyTorch’s autograd API.
Checklist
cc @albanD @jbschlosser