Update hyper params and set seeds#3384
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3384
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4a9b408 with merge base 2c4c99d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@vmoens Mind taking a look at these changes |
vmoens
left a comment
There was a problem hiding this comment.
LGTM
Before approving, do you have a learning curve to share before / after these changes?
| "cpu" | ||
| ) | ||
|
|
||
| # set the seeds for reproducibility |
There was a problem hiding this comment.
Just FYI, we already doing it in the CI, not sure if it's helpful to do something like that for all users...
May be add a paragraph saying to uncomment those if you want fixed output all the time
There was a problem hiding this comment.
I think it's good practice to have it being part of the script and I'd keep it here.
It helps when you run it locally - RL is very seed dependent usually
vmoens
left a comment
There was a problem hiding this comment.
I'm happy with these changes!


Fixes #3080
Description
CartPole-v1environment in the DQN tutorial to better match the results shown in the reference image (only the tutorial file is modified).Checklist