Skip to content

Fix vertical_flip_bounding_boxes wrong corner reorder for XYXYXYXY format#9556

Open
Zenka737 wants to merge 1 commit into
pytorch:mainfrom
Zenka737:fix/vertical-flip-xyxyxyxy-corner-reorder
Open

Fix vertical_flip_bounding_boxes wrong corner reorder for XYXYXYXY format#9556
Zenka737 wants to merge 1 commit into
pytorch:mainfrom
Zenka737:fix/vertical-flip-xyxyxyxy-corner-reorder

Conversation

@Zenka737

Copy link
Copy Markdown

Summary

vertical_flip_bounding_boxes used the same corner reordering index as
horizontal_flip_bounding_boxes for the XYXYXYXY format — a copy-paste
error that produces corners in the wrong order after a vertical flip.

Root Cause

XYXYXYXY stores four corners as [TL, TR, BR, BL] (indices 0–7, pairs of xy).
After flipping all y-coordinates:

  • Horizontal flip swaps TL↔TR and BL↔BR → reorder [2,3, 0,1, 6,7, 4,5]
  • Vertical flip swaps TL↔BL and TR↔BR → reorder must be [6,7, 4,5, 2,3, 0,1]

The vertical-flip path was incorrectly reusing the horizontal-flip index
[2, 3, 0, 1, 6, 7, 4, 5], returning corners as [old-TR, old-TL, old-BL, old-BR]
instead of the correct [new-TL, new-TR, new-BR, new-BL].

Fix

# Before (wrong — copy-pasted from horizontal_flip)
bounding_boxes = bounding_boxes[:, [2, 3, 0, 1, 6, 7, 4, 5]]

# After (correct for vertical flip)
bounding_boxes = bounding_boxes[:, [6, 7, 4, 5, 2, 3, 0, 1]]

@pytorch-bot

pytorch-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9556

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla

meta-cla Bot commented Jul 15, 2026

Copy link
Copy Markdown

Hi @Zenka737!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the cla signed label Jul 15, 2026
@meta-cla

meta-cla Bot commented Jul 15, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant