Fix vertical_flip_bounding_boxes wrong corner reorder for XYXYXYXY format#9556
Fix vertical_flip_bounding_boxes wrong corner reorder for XYXYXYXY format#9556Zenka737 wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9556
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @Zenka737! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
vertical_flip_bounding_boxesused the same corner reordering index ashorizontal_flip_bounding_boxesfor theXYXYXYXYformat — a copy-pasteerror that produces corners in the wrong order after a vertical flip.
Root Cause
XYXYXYXYstores four corners as[TL, TR, BR, BL](indices 0–7, pairs of xy).After flipping all y-coordinates:
[2,3, 0,1, 6,7, 4,5]✓[6,7, 4,5, 2,3, 0,1]The vertical-flip path was incorrectly reusing the horizontal-flip index
[2, 3, 0, 1, 6, 7, 4, 5], returning corners as[old-TR, old-TL, old-BL, old-BR]instead of the correct
[new-TL, new-TR, new-BR, new-BL].Fix