Clean up some comments and minor code improvement (#188)

Author: RealCLanger

pytr/portfolio.py

@@ -9,14 +9,10 @@ def __init__(self, tr):
 
     async def portfolio_loop(self):
         recv = 0
-        # await self.tr.portfolio()
-        # recv += 1
         await self.tr.compact_portfolio()
         recv += 1
         await self.tr.cash()
         recv += 1
-        # await self.tr.available_cash_for_payout()
-        # recv += 1
 
         while recv > 0:
             subscription_id, subscription, response = await self.tr.recv()
@@ -30,9 +26,6 @@ async def portfolio_loop(self):
             elif subscription["type"] == "cash":
                 recv -= 1
                 self.cash = response
-            # elif subscription['type'] == 'availableCashForPayout':
-            #     recv -= 1
-            #     self.payoutCash = response
             else:
                 print(f"unmatched subscription of type '{subscription['type']}':\n{preview(response)}")
 
@@ -51,8 +44,7 @@ async def portfolio_loop(self):
 
             if subscription["type"] == "instrument":
                 await self.tr.unsubscribe(subscription_id)
-                pos = subscriptions[subscription_id]
-                subscriptions.pop(subscription_id, None)
+                pos = subscriptions.pop(subscription_id)
                 pos["name"] = response["shortName"]
                 pos["exchangeIds"] = response["exchangeIds"]
             else:
@@ -73,8 +65,7 @@ async def portfolio_loop(self):
 
             if subscription["type"] == "ticker":
                 await self.tr.unsubscribe(subscription_id)
-                pos = subscriptions[subscription_id]
-                subscriptions.pop(subscription_id, None)
+                pos = subscriptions.pop(subscription_id)
                 pos["netValue"] = float(response["last"]["price"]) * float(pos["netSize"])
             else:
                 print(f"unmatched subscription of type '{subscription['type']}':\n{preview(response)}")
@@ -94,18 +85,13 @@ def portfolio_to_csv(self, output_path):
         print(f"Wrote {len(csv_lines) + 1} lines to {output_path}")
 
     def overview(self):
-        # for x in ['netValue', 'unrealisedProfit', 'unrealisedProfitPercent', 'unrealisedCost']:
-        #     print(f'{x:24}: {self.portfolio[x]:>10.2f}')
-        # print()
-
         print(
             "Name                      ISIN            avgCost *   quantity =    buyCost ->   netValue       diff   %-diff"
         )
         totalBuyCost = 0.0
         totalNetValue = 0.0
         positions = self.portfolio["positions"]
         for pos in sorted(positions, key=lambda x: x["netSize"], reverse=True):
-            # pos['netValue'] = 0 # TODO: Update the value from each Stock request
             buyCost = float(pos["averageBuyIn"]) * float(pos["netSize"])
             diff = float(pos["netValue"]) - buyCost
             if buyCost == 0: