Skip to content

Remove unused dependency importlib_metadata#669

Merged
djhoese merged 3 commits into
pytroll:mainfrom
karyotakisg:main
Aug 4, 2025
Merged

Remove unused dependency importlib_metadata#669
djhoese merged 3 commits into
pytroll:mainfrom
karyotakisg:main

Conversation

@karyotakisg
Copy link
Copy Markdown
Contributor

As part of our ongoing research on Python dependency management we noticed a potential improvement in your project’s dependency management.

Specifically, the dependency importlib_metadata is specified as a requirement in the setup.py file, when in reality it is not needed.

This PR removes it from setup.py, which helps keeping the dependency list clean.
Hope this is helpful!

Best regards

Copy link
Copy Markdown
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice catch. Thanks for making this. I made one small edit and removed one of the extra newlines.

One other small note for the future, as someone who teaches git and maintains a lot of libraries, I'd recommend not using your main branch of your fork for making pull requests. It makes it difficult to sync your fork with the upstream repository (in this case pytroll/pyresample).

@djhoese
Copy link
Copy Markdown
Member

djhoese commented Jul 18, 2025

Ugh CI is failing because of new zarr. I'll have to look at that a different time.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.01%. Comparing base (f5cb4ca) to head (8114c37).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #669   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files          89       89           
  Lines       13614    13614           
=======================================
  Hits        12799    12799           
  Misses        815      815           
Flag Coverage Δ
unittests 94.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 93.705%. remained the same
when pulling 8114c37 on karyotakisg:main
into 89f7787 on pytroll:main.

@djhoese djhoese merged commit f437864 into pytroll:main Aug 4, 2025
36 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants