Remove unused dependency importlib_metadata#669
Conversation
djhoese
left a comment
There was a problem hiding this comment.
Ah nice catch. Thanks for making this. I made one small edit and removed one of the extra newlines.
One other small note for the future, as someone who teaches git and maintains a lot of libraries, I'd recommend not using your main branch of your fork for making pull requests. It makes it difficult to sync your fork with the upstream repository (in this case pytroll/pyresample).
|
Ugh CI is failing because of new zarr. I'll have to look at that a different time. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #669 +/- ##
=======================================
Coverage 94.01% 94.01%
=======================================
Files 89 89
Lines 13614 13614
=======================================
Hits 12799 12799
Misses 815 815
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
As part of our ongoing research on Python dependency management we noticed a potential improvement in your project’s dependency management.
Specifically, the dependency
importlib_metadatais specified as a requirement in thesetup.pyfile, when in reality it is not needed.This PR removes it from
setup.py, which helps keeping the dependency list clean.Hope this is helpful!
Best regards