Skip to content

Update some VIIRS composite definitions to match WMO recommendations#3379

Open
djhoese wants to merge 2 commits intopytroll:mainfrom
djhoese:feat-viirs-day-cloud-comps
Open

Update some VIIRS composite definitions to match WMO recommendations#3379
djhoese wants to merge 2 commits intopytroll:mainfrom
djhoese:feat-viirs-day-cloud-comps

Conversation

@djhoese
Copy link
Copy Markdown
Member

@djhoese djhoese commented Apr 27, 2026

This PR:

  • Adds day_cloud_type_distinction
  • Deprecates cloud_phase_distinction in favor of day_cloud_type_distinction variables
  • Adds day_cloud_type
  • Replaces night_microphysics recipe with night_fog recipe

I think this matches WMO suggestions from the RGB Workshop. @adybbroe I'd like your approval on the night microphysics change.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@djhoese djhoese self-assigned this Apr 27, 2026
@djhoese djhoese added enhancement code enhancements, features, improvements component:compositors backwards-incompatibility Causes backwards incompatibility or introduces a deprecation labels Apr 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.34%. Comparing base (ab7f790) to head (1c7ea63).
⚠️ Report is 272 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3379   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         466      466           
  Lines       59155    59158    +3     
=======================================
+ Hits        56990    56993    +3     
  Misses       2165     2165           
Flag Coverage Δ
behaviourtests 3.58% <ø> (-0.01%) ⬇️
unittests 96.42% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The only minor thing is the support only for I channel versions. For example the compact VIIRSdata we get from EUMETCast has only M channels (and partial DNB) available. I don't think we have a good way to switch between resolutions with dedicated modifiers, so the option is to keep these as-is or add "low res" versions.

@djhoese
Copy link
Copy Markdown
Member Author

djhoese commented Apr 30, 2026

I think I'd always like the highest (best) resolution version of the composite as the "default" and the lowres version as "_lowres" or something similar. I'm not sure what needs to be changed band-wise to make the low res versions. Like is M05 (0.67) really "equivalent" to I01 (0.64)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backwards-incompatibility Causes backwards incompatibility or introduces a deprecation component:compositors enhancement code enhancements, features, improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants