Update some VIIRS composite definitions to match WMO recommendations#3379
Update some VIIRS composite definitions to match WMO recommendations#3379djhoese wants to merge 2 commits intopytroll:mainfrom
Conversation
…nition Removes the DNB-based recipe for night microphysics
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3379 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 466 466
Lines 59155 59158 +3
=======================================
+ Hits 56990 56993 +3
Misses 2165 2165
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pnuu
left a comment
There was a problem hiding this comment.
LGTM.
The only minor thing is the support only for I channel versions. For example the compact VIIRSdata we get from EUMETCast has only M channels (and partial DNB) available. I don't think we have a good way to switch between resolutions with dedicated modifiers, so the option is to keep these as-is or add "low res" versions.
|
I think I'd always like the highest (best) resolution version of the composite as the "default" and the lowres version as "_lowres" or something similar. I'm not sure what needs to be changed band-wise to make the low res versions. Like is M05 (0.67) really "equivalent" to I01 (0.64)? |
This PR:
day_cloud_type_distinctioncloud_phase_distinctionin favor ofday_cloud_type_distinctionvariablesday_cloud_typenight_microphysicsrecipe withnight_fogrecipeI think this matches WMO suggestions from the RGB Workshop. @adybbroe I'd like your approval on the night microphysics change.
AUTHORS.mdif not there already