Skip to content

Use tox for unit testing#271

Merged
user27182 merged 4 commits into
mainfrom
maint/tox
Apr 1, 2026
Merged

Use tox for unit testing#271
user27182 merged 4 commits into
mainfrom
maint/tox

Conversation

@edabor
Copy link
Copy Markdown
Contributor

@edabor edabor commented Mar 23, 2026

This PR introduces tox as CI handler in order to simplify CI configuration and enhance reproducibility with local testing.

@edabor edabor force-pushed the maint/tox branch 5 times, most recently from 415d54c to d22d619 Compare March 24, 2026 10:09
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.68%. Comparing base (48d2414) to head (8e4a713).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files           4        4           
  Lines         965      965           
  Branches      123      123           
=======================================
  Hits          933      933           
  Misses         24       24           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@edabor
Copy link
Copy Markdown
Contributor Author

edabor commented Mar 24, 2026

Waiting for Windows runner from #269

@edabor edabor marked this pull request as ready for review March 26, 2026 13:29
akaszynski
akaszynski previously approved these changes Mar 26, 2026
@user27182
Copy link
Copy Markdown
Contributor

Something is wrong with test coverage. As a side note, project settings might need to be updated so that CI is red if coverage falls below 90% (similar to pyvista CI).

image

@edabor edabor marked this pull request as draft March 26, 2026 15:57
@edabor
Copy link
Copy Markdown
Contributor Author

edabor commented Mar 26, 2026

Something is wrong with test coverage. As a side note, project settings might need to be updated so that CI is red if coverage falls below 90% (similar to pyvista CI).

Looking into it. Sorry for having missed it

@user27182
Copy link
Copy Markdown
Contributor

Something is wrong with test coverage. As a side note, project settings might need to be updated so that CI is red if coverage falls below 90% (similar to pyvista CI).

Looking into it. Sorry for having missed it

To be fair the codecov comment gave misleading checkmarks of approval ✅. I think project settings are the problem for not enforcing this and making coverage thresholds a requirement.

We lost coverage before too: #196 (comment)

Which I believe was fixed by #202. Might be helpful for fixing the issue here too.

@akaszynski akaszynski dismissed their stale review March 26, 2026 16:15

Coverage... thanks user27182

@edabor
Copy link
Copy Markdown
Contributor Author

edabor commented Mar 27, 2026

To be fair the codecov comment gave misleading checkmarks of approval ✅. I think project settings are the problem for not enforcing this and making coverage thresholds a requirement.

We lost coverage before too: #196 (comment)

Which I believe was fixed by #202. Might be helpful for fixing the issue here too.

I'll refactor coverage settings in another PR if it is fine for you.

@edabor
Copy link
Copy Markdown
Contributor Author

edabor commented Mar 27, 2026

Coverage back to its original value

@edabor edabor marked this pull request as ready for review March 27, 2026 10:32
@edabor edabor mentioned this pull request Mar 30, 2026
@user27182 user27182 merged commit 1d91ad1 into main Apr 1, 2026
12 checks passed
@user27182 user27182 deleted the maint/tox branch April 1, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants