Skip to content

Enable faulthandler and force OFF_SCREEN by default#294

Open
banesullivan wants to merge 1 commit into
mainfrom
faulthandler-offscreen-defaults
Open

Enable faulthandler and force OFF_SCREEN by default#294
banesullivan wants to merge 1 commit into
mainfrom
faulthandler-offscreen-defaults

Conversation

@banesullivan
Copy link
Copy Markdown
Member

Every downstream PyVista project sets faulthandler.enable() and pyvista.OFF_SCREEN = True on its own, and the ones that forget get opaque segfaults or hanging headless CI. The plugin now does both: faulthandler is enabled when the plugin is imported, and OFF_SCREEN is forced during configuration.

Behavior change: a project that intentionally runs on-screen under pytest must set pyvista_off_screen = false. faulthandler is enabled unconditionally at import with no opt-out.

resolves #276

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.07%. Comparing base (f030ced) to head (b1343aa).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   96.05%   96.07%   +0.01%     
==========================================
  Files           4        4              
  Lines         988      993       +5     
  Branches      126      127       +1     
==========================================
+ Hits          949      954       +5     
  Misses         29       29              
  Partials       10       10              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

faulthandler and pv.OFF_SCREEN as Defaults

2 participants