rename

Author: pzingg

lib/dmp/patch.ex

@@ -572,7 +572,7 @@ defmodule Dmp.Patch do
     # Imperfect match.  Run a diff to get a framework of equivalent indices.
     diffs = Diff.main_(text1, text2, false, opts)
 
-    if poor_match(diffs, text1, opts) do
+    if bad_match?(diffs, text1, opts) do
       # The end points match, but the content is unacceptably bad.
       {false, text}
     else
@@ -588,7 +588,7 @@ defmodule Dmp.Patch do
   end
 
   # Returns true if the end points match, but the content is unacceptably bad.
-  def poor_match(diffs, text1, opts) do
+  def bad_match?(diffs, text1, opts) do
     text1_length = String.length(text1)
 
     if text1_length > Keyword.fetch!(opts, :match_max_bits) do

test/match_test.exs

@@ -130,11 +130,5 @@ defmodule MatchTest do
                  match_threshold: 0.7
                )
     end
-
-    test "fuzzy score" do
-      {loc, score} = Match.bitap("abcdefghijk", "efxyhi", 1, 0.4, 100, true)
-      assert 4 == loc
-      assert_in_delta 0.36333, score, 0.00001
-    end
   end
 end

test/other_test.exs

@@ -1,8 +1,16 @@
 defmodule OtherTest do
   use ExUnit.Case
 
-  alias Dmp.{Options, StringUtils}
+  alias Dmp.{Match, Options, StringUtils}
 
   doctest Dmp.Options
   doctest Dmp.StringUtils
+
+  describe "bitap scores" do
+    test "inexact match" do
+      {loc, score} = Match.bitap("abcdefghijk", "efxyhi", 1, 0.4, 100, true)
+      assert 4 == loc
+      assert_in_delta 0.36333, score, 0.00001
+    end
+  end
 end