Skip to content

Commit 2143e4e

Browse files
committed
chore: update Go version to 1.25 and improve linter settings
1 parent 3dd95c2 commit 2143e4e

27 files changed

Lines changed: 56 additions & 33 deletions

.github/workflows/ci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,11 @@ jobs:
1717
- uses: actions/setup-go@v6
1818
with:
1919
go-version: "1.26"
20-
- uses: golangci/golangci-lint-action@v6
20+
- uses: golangci/golangci-lint-action@v8
2121
with:
22-
version: latest
22+
# v2.x is required because we target `go 1.26` in go.mod; older
23+
# golangci-lint binaries are built with go1.24 and refuse to load.
24+
version: v2.5.0
2325

2426
test:
2527
runs-on: ubuntu-latest

.golangci.yml

Lines changed: 23 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,35 @@
1+
version: "2"
2+
13
run:
24
timeout: 5m
35

46
linters:
7+
default: none
58
enable:
69
- errcheck
7-
- gofmt
8-
- goimports
910
- govet
1011
- ineffassign
1112
- misspell
13+
- revive
1214
- staticcheck
1315
- unused
14-
- revive
16+
settings:
17+
revive:
18+
rules:
19+
# Disable purely-stylistic rules that flood the output without finding
20+
# real bugs. The rest of revive's defaults stay on.
21+
- name: exported
22+
disabled: true
23+
- name: package-comments
24+
disabled: true
25+
- name: var-naming
26+
disabled: true
27+
exclusions:
28+
rules:
29+
- path: 'resources/.*\.go'
30+
linters: [revive]
1531

16-
issues:
17-
exclude-rules:
18-
- path: resources/.*\.go
19-
linters: [revive]
20-
text: "exported"
32+
formatters:
33+
enable:
34+
- gofmt
35+
- goimports

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ make build
1313
make test
1414
```
1515

16-
Requires Go 1.26+.
16+
Requires Go 1.25+.
1717

1818
## Adding a new resource
1919

README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# stackit-nuke
22

3+
<p align="center">
4+
<img src="docs/assets/nuke.jpg" alt="stackit-nuke" width="420">
5+
</p>
6+
37
> Remove **all** resources from a [STACKIT](https://stackit.de) project. The STACKIT counterpart of [`aws-nuke`](https://github.com/ekristen/aws-nuke), built on the same engine: [`libnuke`](https://github.com/ekristen/libnuke).
48
59
[![ci](https://github.com/qaiser42/stackit-nuke/actions/workflows/ci.yml/badge.svg)](https://github.com/qaiser42/stackit-nuke/actions/workflows/ci.yml)
@@ -154,7 +158,7 @@ make snapshot # goreleaser --snapshot
154158
make docs-serve # mkdocs at localhost:8000
155159
```
156160

157-
Requires Go 1.26+.
161+
Requires Go 1.25+.
158162

159163
### Throwaway test infrastructure
160164

docs/assets/nuke.jpg

51.2 KB
Loading

docs/index.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# stackit-nuke
22

3+
![stackit-nuke](assets/nuke.jpg){ align=right width=320 }
4+
35
`stackit-nuke` removes **all** resources from a [STACKIT](https://stackit.de) project.
46

57
It is the STACKIT equivalent of [`aws-nuke`](https://github.com/ekristen/aws-nuke), [`azure-nuke`](https://github.com/ekristen/azure-nuke) and [`gcp-nuke`](https://github.com/ekristen/gcp-nuke), built on the same engine: [`libnuke`](https://github.com/ekristen/libnuke).

docs/install.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,4 @@ docker run --rm \
3232
go install github.com/qaiser42/stackit-nuke@latest
3333
```
3434

35-
Requires Go 1.26+.
35+
Requires Go 1.25+.

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/qaiser42/stackit-nuke
22

3-
go 1.26
3+
go 1.25
44

55
require (
66
github.com/ekristen/libnuke v1.3.0

resources/compute-keypair.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ func (r *ComputeKeypair) Remove(_ context.Context) error {
3131
return fmt.Errorf("ComputeKeypair.Remove not yet implemented")
3232
}
3333
func (r *ComputeKeypair) Properties() types.Properties { return PropsFromStruct(r) }
34-
func (r *ComputeKeypair) String() string { return r.Name }
34+
func (r *ComputeKeypair) String() string { return r.Name }
3535

3636
type ComputeKeypairLister struct{}
3737

resources/compute-server.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ func (r *ComputeServer) Remove(ctx context.Context) error {
5454
}
5555

5656
func (r *ComputeServer) Properties() types.Properties { return PropsFromStruct(r) }
57-
func (r *ComputeServer) String() string { return r.Name }
57+
func (r *ComputeServer) String() string { return r.Name }
5858

5959
type ComputeServerLister struct{}
6060

0 commit comments

Comments
 (0)