fix(deps): complete urfave/cli v2 to v3 migration (#29)

* fix(deps): complete urfave/cli v2 to v3 migration

PR #26 bumped go.mod to cli/v3 but left all code on v2. Migrate the
CLI to v3: App -> Command, context-aware Action/Before/CommandNotFound,
EnvVars -> Sources, drop removed PathFlag. Tidy drops unused v2.

* ci(renovate): gate gomod major upgrades behind dashboard approval

Major Go module bumps change the import path and break the API, so they
need a manual code migration (cf. the cli/v2->v3 work in this branch).
Require Dependency Dashboard approval so renovate surfaces them without
auto-opening an uncompilable PR.

Author: qaiser42

go.mod

@@ -7,22 +7,18 @@ require (
 	github.com/sirupsen/logrus v1.9.4
 	github.com/stackitcloud/stackit-sdk-go/core v0.26.0
 	github.com/stackitcloud/stackit-sdk-go/services/iaas v1.12.2
-	github.com/urfave/cli/v2 v2.27.7
 	github.com/urfave/cli/v3 v3.9.0
 	gopkg.in/yaml.v3 v3.0.1
 )
 
 require (
-	github.com/cpuguy83/go-md2man/v2 v2.0.7 // indirect
 	github.com/fatih/color v1.18.0 // indirect
 	github.com/golang-jwt/jwt/v5 v5.3.1 // indirect
 	github.com/google/uuid v1.6.0 // indirect
 	github.com/mattn/go-colorable v0.1.13 // indirect
 	github.com/mattn/go-isatty v0.0.20 // indirect
 	github.com/mb0/glob v0.0.0-20160210091149-1eb79d2de6c4 // indirect
-	github.com/russross/blackfriday/v2 v2.1.0 // indirect
 	github.com/stevenle/topsort v0.2.0 // indirect
-	github.com/xrash/smetrics v0.0.0-20240521201337-686a1a2994c1 // indirect
 	golang.org/x/sync v0.14.0 // indirect
 	golang.org/x/sys v0.25.0 // indirect
 )

go.sum

@@ -1,8 +1,3 @@
-github.com/cpuguy83/go-md2man/v2 v2.0.5 h1:ZtcqGrnekaHpVLArFSe4HK5DoKx1T0rq2DwVB0alcyc=
-github.com/cpuguy83/go-md2man/v2 v2.0.5/go.mod h1:tgQtvFlXSQOSOSIRvRPT7W67SCa46tRHOmNcaadrF8o=
-github.com/cpuguy83/go-md2man/v2 v2.0.7 h1:zbFlGlXEAKlwXpmvle3d8Oe3YnkKIK4xSRTd3sHPnBo=
-github.com/cpuguy83/go-md2man/v2 v2.0.7/go.mod h1:oOW0eioCTA6cOiMLiUPZOpcVxMig6NIQQ7OS05n1F4g=
-github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/ekristen/libnuke v1.3.0 h1:HX9FcsmzwA0sWOuaaXUmKnuEgf/5ONwxTDhNJUhElvc=
@@ -30,41 +25,26 @@ github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e h1:fD57ERR4JtEqsWb
 github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e/go.mod h1:zD1mROLANZcx1PVRCS0qkT7pwLkGfwJo4zjcN/Tysno=
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
-github.com/russross/blackfriday/v2 v2.1.0 h1:JIOH55/0cWyOuilr9/qlrm0BSXldqnqwMsf35Ld67mk=
-github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
-github.com/sirupsen/logrus v1.9.3 h1:dueUQJ1C2q9oE3F7wvmSGAaVtTmUizReu6fjN8uqzbQ=
-github.com/sirupsen/logrus v1.9.3/go.mod h1:naHLuLoDiP4jHNo9R0sCBMtWGeIprob74mVsIT4qYEQ=
 github.com/sirupsen/logrus v1.9.4 h1:TsZE7l11zFCLZnZ+teH4Umoq5BhEIfIzfRDZ1Uzql2w=
 github.com/sirupsen/logrus v1.9.4/go.mod h1:ftWc9WdOfJ0a92nsE2jF5u5ZwH8Bv2zdeOC42RjbV2g=
 github.com/stackitcloud/stackit-sdk-go/core v0.26.0 h1:jQEb9gkehfp6VCP6TcYk7BI10cz4l0KM2L6hqYBH2QA=
 github.com/stackitcloud/stackit-sdk-go/core v0.26.0/go.mod h1:WU1hhxnjXw2EV7CYa1nlEvNpMiRY6CvmIOaHuL3pOaA=
-github.com/stackitcloud/stackit-sdk-go/services/iaas v1.11.1 h1:HcKqjwIjv4OAW1aWI0U/JWjnzTwzSvdr6DLasH940EU=
-github.com/stackitcloud/stackit-sdk-go/services/iaas v1.11.1/go.mod h1:Ts06id0KejUlQWbpR+/rm+tKng6QkTuFV1VQTPJ4dA4=
 github.com/stackitcloud/stackit-sdk-go/services/iaas v1.12.2 h1:hWtbUy0UOhw1cE1riCNjvtmbF3zDl717DIcpEEMF9ps=
 github.com/stackitcloud/stackit-sdk-go/services/iaas v1.12.2/go.mod h1:AbPN9BGkdjc+tVsXEX9Vr8BPDjdlDmG26K1FwCKZQVU=
 github.com/stevenle/topsort v0.2.0 h1:LLWgtp34HPX6/RBDRS0kElVxGOTzGBLI1lSAa5Lb46k=
 github.com/stevenle/topsort v0.2.0/go.mod h1:ck2WG2/ZrOr6dLApQ/5Xrqy5wv3T0qhKYWE7r9tkibc=
-github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
-github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
-github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOfJA=
-github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
-github.com/urfave/cli/v2 v2.27.5 h1:WoHEJLdsXr6dDWoJgMq/CboDmyY/8HMMH1fTECbih+w=
-github.com/urfave/cli/v2 v2.27.5/go.mod h1:3Sevf16NykTbInEnD0yKkjDAeZDS0A6bzhBH5hrMvTQ=
-github.com/urfave/cli/v2 v2.27.7 h1:bH59vdhbjLv3LAvIu6gd0usJHgoTTPhCFib8qqOwXYU=
-github.com/urfave/cli/v2 v2.27.7/go.mod h1:CyNAG/xg+iAOg0N4MPGZqVmv2rCoP267496AOXUZjA4=
+github.com/stretchr/testify v1.11.1 h1:7s2iGBzp5EwR7/aIZr8ao5+dra3wiQyKjjFuvgVKu7U=
+github.com/stretchr/testify v1.11.1/go.mod h1:wZwfW3scLgRK+23gO65QZefKpKQRnfz6sD981Nm4B6U=
+github.com/urfave/cli/v3 v3.9.0 h1:AV9lIiPv3ukYnxunaCUsHnEozptYmDN2F0+yWqLMn/c=
 github.com/urfave/cli/v3 v3.9.0/go.mod h1:ysVLtOEmg2tOy6PknnYVhDoouyC/6N42TMeoMzskhso=
-github.com/xrash/smetrics v0.0.0-20240521201337-686a1a2994c1 h1:gEOO8jv9F4OT7lGCjxCBTO/36wtF6j2nSip77qHd4x4=
-github.com/xrash/smetrics v0.0.0-20240521201337-686a1a2994c1/go.mod h1:Ohn+xnUBiLI6FVj/9LpzZWtj1/D6lUovWYBkxHVV3aM=
 golang.org/x/sync v0.14.0 h1:woo0S4Yywslg6hp4eUFjTVOyKt0RookbpAHG4c1HmhQ=
 golang.org/x/sync v0.14.0/go.mod h1:1dzgHSNfp02xaA81J2MS99Qcpr2w7fw1gpm99rleRqA=
-golang.org/x/sys v0.0.0-20220715151400-c0bba94af5f8/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.25.0 h1:r+8e+loiHxRqhXVl6ML1nO3l1+oFoWbnlu2Ehimmi34=
 golang.org/x/sys v0.25.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/check.v1 v1.0.0-20200227125254-8fa46927fb4f h1:BLraFXnmrev5lT+xlilqcH8XK9/i0At2xKjWk4p6zsU=
 gopkg.in/check.v1 v1.0.0-20200227125254-8fa46927fb4f/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
-gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
 gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
 gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=

main.go

@@ -1,11 +1,12 @@
 package main
 
 import (
+	"context"
 	"os"
 	"path"
 
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli/v2"
+	"github.com/urfave/cli/v3"
 
 	"github.com/qaiser42/stackit-nuke/pkg/common"
 
@@ -25,20 +26,18 @@ func main() {
 		}
 	}()
 
-	app := cli.NewApp()
-	app.Name = path.Base(os.Args[0])
-	app.Usage = "remove all resources from a STACKIT project"
-	app.Version = common.AppVersion.Summary
-	app.Authors = []*cli.Author{
-		{Name: "stackit-nuke contributors"},
+	cmd := &cli.Command{
+		Name:     path.Base(os.Args[0]),
+		Usage:    "remove all resources from a STACKIT project",
+		Version:  common.AppVersion.Summary,
+		Authors:  []any{"stackit-nuke contributors"},
+		Commands: common.GetCommands(),
+		CommandNotFound: func(_ context.Context, _ *cli.Command, command string) {
+			logrus.Fatalf("Command %s not found.", command)
+		},
 	}
 
-	app.Commands = common.GetCommands()
-	app.CommandNotFound = func(_ *cli.Context, command string) {
-		logrus.Fatalf("Command %s not found.", command)
-	}
-
-	if err := app.Run(os.Args); err != nil {
+	if err := cmd.Run(context.Background(), os.Args); err != nil {
 		logrus.Fatal(err)
 	}
 }

pkg/commands/global/global.go

@@ -1,12 +1,13 @@
 package global
 
 import (
+	"context"
 	"fmt"
 	"path"
 	"runtime"
 
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli/v2"
+	"github.com/urfave/cli/v3"
 )
 
 func Flags() []cli.Flag {
@@ -15,7 +16,7 @@ func Flags() []cli.Flag {
 			Name:    "log-level",
 			Usage:   "log level",
 			Aliases: []string{"l"},
-			EnvVars: []string{"LOGLEVEL"},
+			Sources: cli.EnvVars("LOGLEVEL"),
 			Value:   "info",
 		},
 		&cli.BoolFlag{Name: "log-caller", Usage: "log caller (file:line)"},
@@ -25,7 +26,7 @@ func Flags() []cli.Flag {
 	}
 }
 
-func Before(c *cli.Context) error {
+func Before(ctx context.Context, c *cli.Command) (context.Context, error) {
 	formatter := &logrus.TextFormatter{
 		DisableColors: c.Bool("log-disable-color"),
 		FullTimestamp: c.Bool("log-full-timestamp"),
@@ -55,5 +56,5 @@ func Before(c *cli.Context) error {
 		logrus.SetLevel(logrus.ErrorLevel)
 	}
 
-	return nil
+	return ctx, nil
 }

pkg/commands/list/command.go

@@ -1,18 +1,19 @@
 package list
 
 import (
+	"context"
 	"fmt"
 	"sort"
 
-	"github.com/urfave/cli/v2"
+	"github.com/urfave/cli/v3"
 
 	"github.com/ekristen/libnuke/pkg/registry"
 
 	"github.com/qaiser42/stackit-nuke/pkg/commands/global"
 	"github.com/qaiser42/stackit-nuke/pkg/common"
 )
 
-func execute(_ *cli.Context) error {
+func execute(_ context.Context, _ *cli.Command) error {
 	names := registry.GetNames()
 	sort.Strings(names)
 	for _, n := range names {

pkg/commands/run/command.go

@@ -7,7 +7,7 @@ import (
 	"time"
 
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli/v2"
+	"github.com/urfave/cli/v3"
 
 	libconfig "github.com/ekristen/libnuke/pkg/config"
 	"github.com/ekristen/libnuke/pkg/filter"
@@ -22,14 +22,14 @@ import (
 	"github.com/qaiser42/stackit-nuke/pkg/stackit"
 )
 
-func execute(c *cli.Context) error {
-	ctx, cancel := context.WithCancel(c.Context)
+func execute(ctx context.Context, c *cli.Command) error {
+	ctx, cancel := context.WithCancel(ctx)
 	defer cancel()
 
 	logger := logrus.StandardLogger()
 
 	parsedConfig, err := config.New(libconfig.Options{
-		Path:         c.Path("config"),
+		Path:         c.String("config"),
 		Deprecations: registry.GetDeprecatedResourceTypeMapping(),
 	})
 	if err != nil {
@@ -162,18 +162,18 @@ func firstNonEmpty(vals ...string) string {
 
 func init() {
 	flags := []cli.Flag{
-		&cli.PathFlag{Name: "config", Usage: "path to config file", Value: "config.yaml"},
+		&cli.StringFlag{Name: "config", Usage: "path to config file", Value: "config.yaml"},
 		&cli.StringSliceFlag{Name: "include", Usage: "only include this specific resource"},
 		&cli.StringSliceFlag{Name: "exclude", Usage: "exclude this specific resource (overrides everything)"},
 		&cli.BoolFlag{Name: "quiet", Aliases: []string{"q"}, Usage: "hide filtered messages"},
 		&cli.BoolFlag{Name: "no-dry-run", Usage: "actually delete after discovery (default: dry-run)"},
 		&cli.BoolFlag{Name: "no-prompt", Aliases: []string{"force"}, Usage: "skip the typed-confirmation prompt"},
 		&cli.IntFlag{Name: "prompt-delay", Aliases: []string{"force-sleep"}, Usage: "seconds to wait after prompt before running (min 3)", Value: 10},
 		&cli.StringSliceFlag{Name: "feature-flag", Usage: "enable experimental behavior"},
-		&cli.StringFlag{Name: "auth-file", Usage: "path to STACKIT service-account key JSON", EnvVars: []string{"STACKIT_SERVICE_ACCOUNT_KEY_PATH"}},
-		&cli.StringFlag{Name: "private-key-file", Usage: "path to RSA private key (for service-account key auth)", EnvVars: []string{"STACKIT_PRIVATE_KEY_PATH"}},
-		&cli.StringFlag{Name: "token", Usage: "STACKIT bearer token", EnvVars: []string{"STACKIT_SERVICE_ACCOUNT_TOKEN"}},
-		&cli.StringSliceFlag{Name: "project-id", Usage: "narrow nuke to one or more project IDs from the config allow-list", EnvVars: []string{"STACKIT_PROJECT_ID"}},
+		&cli.StringFlag{Name: "auth-file", Usage: "path to STACKIT service-account key JSON", Sources: cli.EnvVars("STACKIT_SERVICE_ACCOUNT_KEY_PATH")},
+		&cli.StringFlag{Name: "private-key-file", Usage: "path to RSA private key (for service-account key auth)", Sources: cli.EnvVars("STACKIT_PRIVATE_KEY_PATH")},
+		&cli.StringFlag{Name: "token", Usage: "STACKIT bearer token", Sources: cli.EnvVars("STACKIT_SERVICE_ACCOUNT_TOKEN")},
+		&cli.StringSliceFlag{Name: "project-id", Usage: "narrow nuke to one or more project IDs from the config allow-list", Sources: cli.EnvVars("STACKIT_PROJECT_ID")},
 	}
 
 	cmd := &cli.Command{

pkg/common/commands.go

@@ -2,7 +2,7 @@ package common
 
 import (
 	"github.com/sirupsen/logrus"
-	"github.com/urfave/cli/v2"
+	"github.com/urfave/cli/v3"
 )
 
 var commands []*cli.Command

renovate.json

@@ -26,6 +26,13 @@
       "matchUpdateTypes": ["minor", "patch"],
       "groupName": "go modules (non-major)"
     },
+    {
+      "description": "Go module major upgrades change the import path and usually break the API — they need a manual code migration. Gate behind Dependency Dashboard approval so renovate surfaces them but never auto-opens an uncompilable PR.",
+      "matchManagers": ["gomod"],
+      "matchUpdateTypes": ["major"],
+      "dependencyDashboardApproval": true,
+      "automerge": false
+    },
     {
       "description": "libnuke — manual, own PR so it doesn't block the group's automerge",
       "matchPackageNames": ["github.com/ekristen/libnuke"],